You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/19 16:34:20 UTC
[GitHub] [couchdb-helm] rileyai-dev opened a new pull request, #104: Simplify secrets to avoid dependencies on a file and keep only the se…
rileyai-dev opened a new pull request, #104:
URL: https://github.com/apache/couchdb-helm/pull/104
…cret information
<!--
Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
make sure you are aware of the chart technical requirements and best practices:
* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.
Please make sure you test your changes before you push them.
-->
#### What this PR does / why we need it:
It simplify the secret. Instead of relying on password.ini, it simply store the values. It helps users better manage their own secret files when they set `createAdminSecret` to false.
#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
- fixes #
#### Special notes for your reviewer:
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [x] Chart Version bumped
- [x] e2e tests pass
- [x] Variables are documented in the README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] yekibud commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
yekibud commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1362300490
Hi @rileyai-dev . I've been getting the following on my PRs trying to run the e2e tests. It appears these tests are passing without any errors for you? Is there anything special about the way you runt the tests? I just run `make test` from the project root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] rileyai-dev commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
rileyai-dev commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1374618836
@willholley Would highly appreciate if you could have a look at this. I added a new autoSetup feature to automatically finalize the cluster (set to false by default). It's very useful for fluxCD or equivalent tools!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] rileyai-dev closed pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
rileyai-dev closed pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
URL: https://github.com/apache/couchdb-helm/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1374836019
@rileyai-dev the autoSetup feature seems like it should be a distinct PR, else it's tricky to untangle the changes related to each enhancement for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] yekibud commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
yekibud commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1364241788
Oh, okay, I thought you had run the test because the "e2e tests pass" checkbox was checked in the PR. If you get a chance to run `make test` I would be curious to see if it passes for you or not.
I think building the package should just be creating a new tarball and updating the index with `helm repo index docs`. However, this doesn't seem to updating the helm repo itself, which I [noted in my current PR](https://github.com/apache/couchdb-helm/pull/105#issue-1507135800).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] rileyai-dev commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
rileyai-dev commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1363958202
Thanks for the reply! Actually I haven't tried the test... I have created my own chart package and I am currently using it in my environment. I see that the test you run is mentioning 3.6.3 while I have bumped the version of the chart to 3.7.0 (I did so to reflect the change for users who might already have an existing secret).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] rileyai-dev commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
Posted by GitBox <gi...@apache.org>.
rileyai-dev commented on PR #104:
URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1374849936
@willholley I have created a new [PR-106](https://github.com/apache/couchdb-helm/pull/106) for the admin hash only. I will submit a new one for autoSetup asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org