You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "songwdfu (via GitHub)" <gi...@apache.org> on 2025/07/29 20:51:52 UTC
[PR] [SSE] Partitioned groupby combine - Producer Consumer [pinot]
songwdfu opened a new pull request, #16452:
URL: https://github.com/apache/pinot/pull/16452
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [SSE] Partitioned groupby combine - Producer Consumer [pinot]
Posted by "songwdfu (via GitHub)" <gi...@apache.org>.
songwdfu commented on PR #16452:
URL: https://github.com/apache/pinot/pull/16452#issuecomment-3156315349
Several benchmark results showing ~40% query latency reduction when LIMIT is effective
new
```
Benchmark (_limit) (_numRows) (_numSegments) (_query) (_scenario) Mode Cnt Score Error Units
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 50 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 195.605 ± 68.389 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 100 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 348.517 ± 197.031 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 200 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 821.036 ± 192.112 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 300 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 1440.778 ± 289.821 ms/op
```
old
```
Benchmark (_limit) (_numRows) (_numSegments) (_query) (_scenario) Mode Cnt Score Error Units
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 50 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 495.537 ± 56.197 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 100 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 920.710 ± 71.546 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 200 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 1819.569 ± 130.691 ms/op
BenchmarkPartitionedGroupByQueriesSSE.query 10000 15000 300 SELECT RAW_STRING_COL,STRING_COL,COUNT(*) FROM MyTable GROUP BY RAW_STRING_COL,STRING_COL ORDER BY COUNT(*) EXP(0.0001) avgt 5 2735.284 ± 160.252 ms/op
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [SSE] Partitioned groupby combine - Producer Consumer [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16452:
URL: https://github.com/apache/pinot/pull/16452#issuecomment-3134154963
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16452?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.67292%` with `271 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.37%. Comparing base ([`1a476de`](https://app.codecov.io/gh/apache/pinot/commit/1a476dea72ebf1c15e14ded28ae60c385f71b2c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d09a1b`](https://app.codecov.io/gh/apache/pinot/commit/8d09a1bd17c8808e8ab9f429bd00bb5c1c51c4f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 530 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/16452?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...org/apache/pinot/core/data/table/TableResizer.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FTableResizer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1RhYmxlUmVzaXplci5qYXZh) | 48.41% | [60 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...data/table/TwoLevelLinearProbingRecordHashMap.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FTwoLevelLinearProbingRecordHashMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1R3b0xldmVsTGluZWFyUHJvYmluZ1JlY29yZEhhc2hNYXAuamF2YQ==) | 72.19% | [43 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pinot/core/data/table/PartitionedIndexedTable.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FPartitionedIndexedTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1BhcnRpdGlvbmVkSW5kZXhlZFRhYmxlLmphdmE=) | 37.87% | [35 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pinot/core/data/table/RadixPartitionedHashMap.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FRadixPartitionedHashMap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JhZGl4UGFydGl0aW9uZWRIYXNoTWFwLmphdmE=) | 45.58% | [35 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...t/core/data/table/TwoLevelHashMapIndexedTable.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FTwoLevelHashMapIndexedTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1R3b0xldmVsSGFzaE1hcEluZGV4ZWRUYWJsZS5qYXZh) | 59.70% | [16 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Futil%2FGroupByUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | 53.33% | [15 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../core/operator/combine/GroupByCombineOperator.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Foperator%2Fcombine%2FGroupByCombineOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9jb21iaW5lL0dyb3VwQnlDb21iaW5lT3BlcmF0b3IuamF2YQ==) | 86.50% | [10 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ata/table/RadixPartitionedIntermediateRecords.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FRadixPartitionedIntermediateRecords.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JhZGl4UGFydGl0aW9uZWRJbnRlcm1lZGlhdGVSZWNvcmRzLmphdmE=) | 89.74% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/pinot/core/data/table/IndexedTable.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fdata%2Ftable%2FIndexedTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0luZGV4ZWRUYWJsZS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pinot/core/query/request/context/QueryContext.java](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Frequest%2Fcontext%2FQueryContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZXF1ZXN0L2NvbnRleHQvUXVlcnlDb250ZXh0LmphdmE=) | 80.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [3 more](https://app.codecov.io/gh/apache/pinot/pull/16452?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (1a476de) and HEAD (8d09a1b). Click for more details.
>
> <details><summary>HEAD has 68 uploads less than BASE</summary>
>
>| Flag | BASE (1a476de) | HEAD (8d09a1b) |
>|------|------|------|
>|java-21|10|1|
>|unittests|6|1|
>|unittests1|3|1|
>|skip-bytebuffers-true|4|0|
>|temurin|15|1|
>|unittests2|3|0|
>|skip-bytebuffers-false|8|0|
>|java-11|5|0|
>|integration|9|0|
>|integration2|3|0|
>|integration1|3|0|
>|custom-integration1|3|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16452 +/- ##
============================================
- Coverage 62.90% 56.37% -6.54%
+ Complexity 1386 699 -687
============================================
Files 2867 2355 -512
Lines 163354 130232 -33122
Branches 24952 20738 -4214
============================================
- Hits 102755 73414 -29341
+ Misses 52847 50757 -2090
+ Partials 7752 6061 -1691
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <63.67%> (-6.46%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <63.67%> (-6.54%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <63.67%> (-6.53%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.37% <63.67%> (+0.55%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16452?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org