You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2022/01/19 21:32:36 UTC

[GitHub] [struts] yasserzamani commented on pull request #496: fix double evaluations

yasserzamani commented on pull request #496:
URL: https://github.com/apache/struts/pull/496#issuecomment-1016886548


   @aleksandr-m thanks for asking! Now by merging upstream into this branch by me, a test of TextField has two dynamic parameters set (one added by Lukasz). Then I saw that tests are passing with jdk7 and are failing with jdk8 and newer. Then I realized that different JDKs return different `order` for HashMap.entrySet(). So I changed to LinkedHashMap which keeps order to avoid a workaround like [click here](https://github.com/apache/struts/blob/8d0382c34e2cd9fcb6a53cd9ab5f76d81b0104c8/core/src/test/java/org/apache/struts2/views/freemarker/FreemarkerResultMockedTest.java#L121). Furthermore I think it's nice to keep dynamic attributes order same as added by user. And at bottom, LinkedHashMap is also a Map so I think it shouldn't be a breaking change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org