You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/07 07:38:04 UTC

[GitHub] [flink] link3280 opened a new pull request #10113: [FLINK-13749][client] Make PackagedProgram respect classloading policy

link3280 opened a new pull request #10113: [FLINK-13749][client] Make PackagedProgram respect classloading policy
URL: https://github.com/apache/flink/pull/10113
 
 
   ## What is the purpose of the change
   Currently, Flink client (PackagedProgram) does not respect the classloading policy and uses hardcoded parent-first classloader, while the other components like jobmanager and taskmanager use child-first classloader by default and respect the classloading options. This makes the client more likely to have dependency conflicts, especially after we removed the convenient hadoop binaries (so users need to add hadoop classpath in the client classpath).
   
   ## Brief change log
   
     - *Add configuration to PackagedProgram construtors.*
     - *Determind PackagedProgram classloader with respect to classloader resolve-order and parent-first pattern in the configuration.*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Add tests in ClassLoaderITCase to check classloading orders in PackagedProgram execution.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services