You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Kent Tong (JIRA)" <ji...@apache.org> on 2006/05/13 08:42:09 UTC

[jira] Created: (AXIS2-727) Inconsistency in generated Callback handler

Inconsistency in generated Callback handler 
--------------------------------------------

         Key: AXIS2-727
         URL: http://issues.apache.org/jira/browse/AXIS2-727
     Project: Apache Axis 2.0 (Axis2)
        Type: Bug

  Components: Tools  
    Versions: 1.0    
 Environment: Axis2 1.0 RC4
    Reporter: Kent Tong


The generated Callback Handler class is declared as abstract, meaning that the user is supposed to create a subclass from it. However, the clientData field is declared as private and there is no getter, so the subclass won't be able to access it. In addition, as it is intended to be subclassed, the method comment shouldn't suggest the user to fill in the code:

<pre>
public abstract class FooServiceCallbackHandler {
	private Object clientData;

	public void receiveResultadd(com.foo.sc.AddResponse param11) {
		// Fill here with the code to handle the response
	}
	public void receiveErroradd(java.lang.Exception e) {
		// Fill here with the code to handle the exception
	}
}
</pre>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (AXIS2-727) Inconsistency in generated Callback handler

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-727?page=all ]
     
Davanum Srinivas resolved AXIS2-727:
------------------------------------

    Resolution: Fixed

added a getter for client data, removed the comments on adding user code, added a comment on extending the class.

thanks,
dims

> Inconsistency in generated Callback handler
> -------------------------------------------
>
>          Key: AXIS2-727
>          URL: http://issues.apache.org/jira/browse/AXIS2-727
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug

>   Components: Tools
>     Versions: 1.0
>  Environment: Axis2 1.0 RC4
>     Reporter: Kent Tong
>     Assignee: Ajith Harshana Ranabahu

>
> The generated Callback Handler class is declared as abstract, meaning that the user is supposed to create a subclass from it. However, the clientData field is declared as private and there is no getter, so the subclass won't be able to access it. In addition, as it is intended to be subclassed, the method comment shouldn't suggest the user to fill in the code:
> <pre>
> public abstract class FooServiceCallbackHandler {
> 	private Object clientData;
> 	public void receiveResultadd(com.foo.sc.AddResponse param11) {
> 		// Fill here with the code to handle the response
> 	}
> 	public void receiveErroradd(java.lang.Exception e) {
> 		// Fill here with the code to handle the exception
> 	}
> }
> </pre>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (AXIS2-727) Inconsistency in generated Callback handler

Posted by "Ajith Harshana Ranabahu (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2-727?page=comments#action_12411952 ] 

Ajith Harshana Ranabahu commented on AXIS2-727:
-----------------------------------------------

Another small addition from me - making the client object protected :)

> Inconsistency in generated Callback handler
> -------------------------------------------
>
>          Key: AXIS2-727
>          URL: http://issues.apache.org/jira/browse/AXIS2-727
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug

>   Components: Tools
>     Versions: 1.0
>  Environment: Axis2 1.0 RC4
>     Reporter: Kent Tong
>     Assignee: Ajith Harshana Ranabahu

>
> The generated Callback Handler class is declared as abstract, meaning that the user is supposed to create a subclass from it. However, the clientData field is declared as private and there is no getter, so the subclass won't be able to access it. In addition, as it is intended to be subclassed, the method comment shouldn't suggest the user to fill in the code:
> <pre>
> public abstract class FooServiceCallbackHandler {
> 	private Object clientData;
> 	public void receiveResultadd(com.foo.sc.AddResponse param11) {
> 		// Fill here with the code to handle the response
> 	}
> 	public void receiveErroradd(java.lang.Exception e) {
> 		// Fill here with the code to handle the exception
> 	}
> }
> </pre>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (AXIS2-727) Inconsistency in generated Callback handler

Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2-727?page=all ]

Deepal Jayasinghe reassigned AXIS2-727:
---------------------------------------

    Assign To: Ajith Harshana Ranabahu

> Inconsistency in generated Callback handler
> -------------------------------------------
>
>          Key: AXIS2-727
>          URL: http://issues.apache.org/jira/browse/AXIS2-727
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug

>   Components: Tools
>     Versions: 1.0
>  Environment: Axis2 1.0 RC4
>     Reporter: Kent Tong
>     Assignee: Ajith Harshana Ranabahu

>
> The generated Callback Handler class is declared as abstract, meaning that the user is supposed to create a subclass from it. However, the clientData field is declared as private and there is no getter, so the subclass won't be able to access it. In addition, as it is intended to be subclassed, the method comment shouldn't suggest the user to fill in the code:
> <pre>
> public abstract class FooServiceCallbackHandler {
> 	private Object clientData;
> 	public void receiveResultadd(com.foo.sc.AddResponse param11) {
> 		// Fill here with the code to handle the response
> 	}
> 	public void receiveErroradd(java.lang.Exception e) {
> 		// Fill here with the code to handle the exception
> 	}
> }
> </pre>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira