[GitHub] [lucene-solr] jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #916: LUCENE-8213: Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/916#discussion_r330550479
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/QueryCache.java
 ##########
 @@ -33,4 +35,10 @@
    */
   Weight doCache(Weight weight, QueryCachingPolicy policy);
 
+  /**
+   * Same as above, but allows passing in an Executor to perform caching
+   * asynchronously
+   */
+  Weight doCache(Weight weight, QueryCachingPolicy policy, Executor executor);
 
 Review comment:
   Let's remove the other doCache and only have this one, with a `null` executor signaling that things should get cached in the current thread?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org