You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/28 08:57:15 UTC

[GitHub] [pulsar] zymap opened a new pull request, #15367: [fix][package-management] Fix the new path `/data` introduced regression

zymap opened a new pull request, #15367:
URL: https://github.com/apache/pulsar/pull/15367

   ---
   
   Fixes #15362
   
   *Motivation*
   
   The PR https://github.com/apache/pulsar/pull/13218 supports saving
   package data into filesystem. But it introduces a regression for the
   old versions.
   For example, we have a package function://public/default/package@v0.1,
   it will save the meta to the path function/public/default/package/v0.1/meta,
   and save the data to the path function/public/default/package/v0.1.
   By default, we are using distributed log as the package storage, and
   it supports saving data in a directory.
   But some storage like filesystem doesn't have the similar ability, it
   needs another path for saving data.
   This API provides the ability to support saving the data in another place.
   If you specify the data path as `/data`, the package will be saved into
   function/public/default/package/v0.1/data.
   
   *Modifications*
   
   - make the data path configurable in the storage implementation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #15367: [fix][package-management] Fix the new path `/data` introduced regression

Posted by GitBox <gi...@apache.org>.

zymap commented on PR #15367:
URL: https://github.com/apache/pulsar/pull/15367#issuecomment-1118234261

   @nicoloboschi PTAL. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #15367: [fix][package-management] Fix the new path `/data` introduced regression

Posted by GitBox <gi...@apache.org>.

zymap commented on PR #15367:
URL: https://github.com/apache/pulsar/pull/15367#issuecomment-1112833308

   ping @merlimat @eolivelli 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #15367: [fix][package-management] Fix the new path `/data` introduced regression

Posted by GitBox <gi...@apache.org>.

zymap commented on PR #15367:
URL: https://github.com/apache/pulsar/pull/15367#issuecomment-1111939186

   @nlu90 @eolivelli PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap commented on pull request #15367: [fix][package-management] Fix the new path `/data` introduced regression

Posted by GitBox <gi...@apache.org>.

zymap commented on PR #15367:
URL: https://github.com/apache/pulsar/pull/15367#issuecomment-1111938176

   We have tests for the package service both bk storage and filesystem storage. It's a compatibility issue so I think it's hard to add a test for that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] zymap merged pull request #15367: [fix][package-management] Fix the new path `/data` introduced regression

Posted by GitBox <gi...@apache.org>.

zymap merged PR #15367:
URL: https://github.com/apache/pulsar/pull/15367


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org