[GitHub] [flink] Myasuka opened a new pull request #8909: [FLINK-13004][table-runtime-blink] Correct the logic of needToCleanupState in KeyedProcessFunctionWithCleanupState

[GitBox <gi...@apache.org>]

Myasuka opened a new pull request #8909: [FLINK-13004][table-runtime-blink] Correct the logic of needToCleanupState in KeyedProcessFunctionWithCleanupState
URL: https://github.com/apache/flink/pull/8909
 
 
   
   ## What is the purpose of the change
   
   Current implementation of `#needToCleanupState` in `KeyedProcessFunctionWithCleanupState` used incorrect way to judge whether the time should cleaned up. We should sue `equals` instead of `==` to compare wrapper type of Long. 
   
   ## Brief change log
   
     - Correct the logic of `#needToCleanupState` in `KeyedProcessFunctionWithCleanupState`.
     - Correct the check logic of  whether there are still records which have not been processed yet in `AbstractRowTimeUnboundedPrecedingOver`.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Updated test of `OverWindowHarnessTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services