You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/06 10:21:09 UTC
[PR] [SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message [spark]
uros-b opened a new pull request, #57821:
URL: https://github.com/apache/spark/pull/57821
### What changes were proposed in this pull request?
Fixes the scalafmt failure message in `dev/lint-scala`, which names the same path twice:
```
The scalafmt check failed on sql/connect or sql/connect at following occurrences:
```
The first path is corrected to `sql/api`, so the message reads `sql/api or sql/connect`.
### Why are the changes needed?
The check runs over `sql/api` plus four modules under `sql/connect` (`common`, `server`, `shims`, `client/jvm`), so `sql/connect or sql/connect` is a tautology that tells the reader nothing about the first module. The corrected wording matches the `-pl` module list printed on the very next line of the same script.
The duplication is a leftover of the module rename in SPARK-49428: the message previously read `sql/connect or connector/connect`, and applying the `connector/connect` to `sql/connect` rename to the message text collapsed both halves to the same path. The `sql/api` module had been added to the check earlier, in SPARK-49511, without the message being updated.
### Does this PR introduce _any_ user-facing change?
No. Developer-facing message text in a lint script only.
### How was this patch tested?
No functional change. The edited string is inside an existing `echo -e` and no test, CI workflow, or doc matches on this message text, so nothing consumes it programmatically.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57821:
URL: https://github.com/apache/spark/pull/57821#issuecomment-5215554644
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/81ff2a6de7717cb868acd21e7960f9e870e7c006
- merged into branch-4.x https://github.com/apache/spark/commit/2c9a03d5de346d6863a8aa85c022718a1d72ca9d
- merged into branch-4.3 https://github.com/apache/spark/commit/4878aab6bfc26945608c6918322f5feb5a3f65d3
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57821: [SPARK-58618][BUILD] Fix duplicated path in lint-scala scalafmt failure message
URL: https://github.com/apache/spark/pull/57821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org