[GitHub] [bookkeeper] rudy2steiner commented on a change in pull request #2403: Issue 2388: Bookie Http Service Servlet for Embedded Bookie

[GitBox <gi...@apache.org>]

rudy2steiner commented on a change in pull request #2403:
URL: https://github.com/apache/bookkeeper/pull/2403#discussion_r507015426



##########
File path: bookkeeper-http/servlet-http-server/src/main/java/org/apache/bookkeeper/http/servlet/JettyHttpServer.java
##########
@@ -0,0 +1,59 @@
+package org.apache.bookkeeper.http.servlet;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.nio.file.Files;
+import java.util.List;
+import javax.servlet.Servlet;
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.handler.ContextHandlerCollection;
+import org.eclipse.jetty.servlet.ServletHolder;
+import org.eclipse.jetty.webapp.WebAppContext;
+
+/**
+ * Jetty based http server
+ **/
+
+public class JettyHttpServer {

Review comment:
       > Please move this class to the tests sources.
   > This is not intended to be used
   
   done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org