You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/02/27 01:49:00 UTC
[GitHub] jixuan1989 commented on a change in pull request #72: Fix Bug
[IOTDB-22] in JIRA
jixuan1989 commented on a change in pull request #72: Fix Bug [IOTDB-22] in JIRA
URL: https://github.com/apache/incubator-iotdb/pull/72#discussion_r260564175
##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/read/TsFileSequenceReader.java
##########
@@ -258,9 +258,7 @@ public PageHeader readPageHeader(TSDataType type) throws IOException {
* @param position the file offset of this page header's header
*/
public PageHeader readPageHeader(TSDataType type, long position) throws IOException {
- int size = PageHeader.calculatePageHeaderSize(type);
- ByteBuffer buffer = readData(position, size);
- return PageHeader.deserializeFrom(buffer, type);
+ return PageHeader.deserializeFrom(tsFileInput.wrapAsInputStream(), type);
Review comment:
you omit the parameter of position....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services