You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/05/26 17:52:28 UTC
[superset] 01/01: fix big quert edit form
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/fix-big-edit
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f8a42da064229d0d471c57d64c2bbdf9132cd62b
Author: hughhhh <hu...@gmail.com>
AuthorDate: Wed May 26 13:51:10 2021 -0400
fix big quert edit form
---
superset/db_engine_specs/bigquery.py | 2 +-
superset/models/core.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/superset/db_engine_specs/bigquery.py b/superset/db_engine_specs/bigquery.py
index 0fca504..7320eab 100644
--- a/superset/db_engine_specs/bigquery.py
+++ b/superset/db_engine_specs/bigquery.py
@@ -49,7 +49,7 @@ ma_plugin = MarshmallowPlugin()
class BigQueryParametersSchema(Schema):
credentials_info = EncryptedField(
- description="Contents of BigQuery JSON credentials.",
+ required=True, description="Contents of BigQuery JSON credentials.",
)
diff --git a/superset/models/core.py b/superset/models/core.py
index 540974f..b5f73fe 100755
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -246,7 +246,7 @@ class Database(
self.db_engine_spec, "get_parameters_from_uri"
):
uri = make_url(self.sqlalchemy_uri_decrypted)
- return {**parameters, **self.db_engine_spec.get_parameters_from_uri(uri)} # type: ignore
+ return {**parameters, **self.db_engine_spec.get_parameters_from_uri(uri, self.get_encrypted_extra())} # type: ignore
return parameters