You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/06 11:41:36 UTC

[GitHub] [apisix-ingress-controller] Belyenochi commented on a change in pull request #896: feat: support custom registry for e2e test

Belyenochi commented on a change in pull request #896:
URL: https://github.com/apache/apisix-ingress-controller/pull/896#discussion_r820221275



##########
File path: Makefile
##########
@@ -19,6 +19,7 @@ default: help
 VERSION ?= 1.4.0
 RELEASE_SRC = apache-apisix-ingress-controller-${VERSION}-src
 LOCAL_REGISTRY="localhost:5000"
+CUSTOM_REGISTRY ?= ""

Review comment:
       Thanks for review @tao12345666333 @lingsamuel, I've tried renaming REGISTRY, here I'm worried if the kind-up part is needed, I think we should check if REGISTRY points to kind and then run the judgment?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org