You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/11/30 16:02:48 UTC

Review Request 64214: Log Search UI: layout and behaviour changes for filtering

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64214/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22564
    https://issues.apache.org/jira/browse/AMBARI-22564


Repository: ambari


Description
-------

1. Move filter by cluster to top right (on the left from menu icon) and display it only if there are more than one cluster available.
2. Add Search button to the right from timezone selector
3. Filtering by parameters from search box should be applied either by clicking Search button
4. Change “Excluded” to “Exclude”


Diffs
-----

  ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less 880a97b 
  ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts 58e0025 
  ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.html d6e9091 
  ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html b5f1e56 
  ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less d767e15 
  ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts 148e1b4 
  ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html 4fe169d 
  ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less 962199b 
  ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts 01a8932 
  ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less 0207561 
  ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less 4460821 
  ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html 4be0a47 
  ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html 5bffdc5 
  ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less eac3bd6 
  ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts 14cc89b 
  ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.html a2e666e 
  ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.less bd6d012 
  ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html 369ddd4 
  ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less 32d1beb 
  ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.spec.ts 6679ba1 
  ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts 91f27e8 
  ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 18268ad 
  ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 64b14b8 
  ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 98b9e29 
  ambari-logsearch/ambari-logsearch-web/webpack.config.js 75d6aee 


Diff: https://reviews.apache.org/r/64214/diff/1/


Testing
-------

Executed 211 of 211 SUCCESS (4.549 secs / 4.463 secs)


Thanks,

Andrii Babiichuk


Re: Review Request 64214: Log Search UI: layout and behaviour changes for filtering

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64214/#review192303
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 30, 2017, 4:02 п.п., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64214/
> -----------------------------------------------------------
> 
> (Updated Ноя. 30, 2017, 4:02 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22564
>     https://issues.apache.org/jira/browse/AMBARI-22564
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Move filter by cluster to top right (on the left from menu icon) and display it only if there are more than one cluster available.
> 2. Add Search button to the right from timezone selector
> 3. Filtering by parameters from search box should be applied either by clicking Search button
> 4. Change “Excluded” to “Exclude”
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less 880a97b 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts 58e0025 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/audit-logs-table/audit-logs-table.component.html d6e9091 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html b5f1e56 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less d767e15 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts 148e1b4 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html 4fe169d 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less 962199b 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts 01a8932 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less 0207561 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less 4460821 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html 4be0a47 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html 5bffdc5 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less eac3bd6 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts 14cc89b 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.html a2e666e 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/service-logs-table/service-logs-table.component.less bd6d012 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html 369ddd4 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less 32d1beb 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.spec.ts 6679ba1 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts 91f27e8 
>   ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less 18268ad 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts 64b14b8 
>   ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 98b9e29 
>   ambari-logsearch/ambari-logsearch-web/webpack.config.js 75d6aee 
> 
> 
> Diff: https://reviews.apache.org/r/64214/diff/1/
> 
> 
> Testing
> -------
> 
> Executed 211 of 211 SUCCESS (4.549 secs / 4.463 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>