You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 13:42:31 UTC
[GitHub] [flink] AHeise opened a new pull request #10816: Flink 15355
AHeise opened a new pull request #10816: Flink 15355
URL: https://github.com/apache/flink/pull/10816
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fixed parsing of plugin parent-first patterns.
Previously, empty options would result in an empty pattern, which matches everything. Thus, we effectively got parent first for all classes.
## Brief change log
- Fix in CoreOptions for parsing of plugin parent-first patterns.
## Verifying this change
- File Sink e2e tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no /** don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364788984
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -133,7 +127,7 @@
.withDescription("A (semicolon-separated) list of patterns that specifies which classes should always be" +
" resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked " +
" against the fully qualified class name. This setting should generally not be modified. To add another " +
- " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.GuavaFlinkConnectorRateLimiteradditional\" instead.");
Review comment:
woooops, good catch. that would have been weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #10816: [Flink-15355] Fixed
parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364749735
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -25,6 +25,9 @@
import org.apache.flink.configuration.description.Description;
import org.apache.flink.util.ArrayUtils;
+import org.apache.flink.shaded.guava18.com.google.common.base.Splitter;
+import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
Review comment:
I think the decision is that we shouldn't be adding more guava dependencies/usages in our code base. At least that's the feedback once I tried to pull out the same trick you did ("guava already present, so why not to use it?").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364770675
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -25,6 +25,9 @@
import org.apache.flink.configuration.description.Description;
import org.apache.flink.util.ArrayUtils;
+import org.apache.flink.shaded.guava18.com.google.common.base.Splitter;
+import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
Review comment:
Ok, I don't have any strong preference in that matter :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on issue #10816: [Flink-15355] Fixed
parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
AHeise commented on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572780051
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364768782
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -147,8 +150,8 @@
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
-
- return ArrayUtils.concat(base.split(";"), append.split(";"));
+ final Splitter splitter = Splitter.on(';').omitEmptyStrings();
+ return Iterables.toArray(Iterables.concat(splitter.split(base), splitter.split(append)), String.class);
}
Review comment:
Added a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364757768
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -25,6 +25,9 @@
import org.apache.flink.configuration.description.Description;
import org.apache.flink.util.ArrayUtils;
+import org.apache.flink.shaded.guava18.com.google.common.base.Splitter;
+import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
Review comment:
Discussion came up when the `GuavaFlinkConnectorRateLimiter` was added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364770813
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -147,8 +150,8 @@
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
-
- return ArrayUtils.concat(base.split(";"), append.split(";"));
+ final Splitter splitter = Splitter.on(';').omitEmptyStrings();
+ return Iterables.toArray(Iterables.concat(splitter.split(base), splitter.split(append)), String.class);
}
Review comment:
And what about the deduplication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364784743
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -133,7 +127,7 @@
.withDescription("A (semicolon-separated) list of patterns that specifies which classes should always be" +
" resolved through the plugin parent ClassLoader first. A pattern is a simple prefix that is checked " +
" against the fully qualified class name. This setting should generally not be modified. To add another " +
- " pattern we recommend to use \"plugin.classloader.parent-first-patterns.additional\" instead.");
+ " pattern we recommend to use \"plugin.classloader.parent-first-patterns.GuavaFlinkConnectorRateLimiteradditional\" instead.");
Review comment:
`GuavaFlinkConnectorRateLimiteradditional`
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10816: [Flink-15355] Fixed
parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10816: Flink 15355
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10816: Flink 15355
URL: https://github.com/apache/flink/pull/10816#issuecomment-572568717
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8f7604d34d7048aa46ec86671b43548f88369bb2 (Thu Jan 09 13:47:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:MANUAL TriggerID:572780051
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:MANUAL TriggerID:572780051
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:MANUAL TriggerID:572780051
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364770813
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -147,8 +150,8 @@
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
-
- return ArrayUtils.concat(base.split(";"), append.split(";"));
+ final Splitter splitter = Splitter.on(';').omitEmptyStrings();
+ return Iterables.toArray(Iterables.concat(splitter.split(base), splitter.split(append)), String.class);
}
Review comment:
And what about the deduplication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:MANUAL TriggerID:572780051
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:MANUAL TriggerID:572780051
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364750757
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -147,8 +150,8 @@
public static String[] getPluginParentFirstLoaderPatterns(Configuration config) {
String base = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
String append = config.getString(PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
-
- return ArrayUtils.concat(base.split(";"), append.split(";"));
+ final Splitter splitter = Splitter.on(';').omitEmptyStrings();
+ return Iterables.toArray(Iterables.concat(splitter.split(base), splitter.split(append)), String.class);
}
Review comment:
Can you deduplicate this code with `getParentFirstLoaderPatterns`? Provide a base method `private static String[] getParentFirstLoaderPatterns(String base, String append)`? Especially that the original method that was copied/duplicated didn't have the bug.
Also maybe a unit test since this has failed/caused a bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10816:
[Flink-15355] Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#discussion_r364757389
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##########
@@ -25,6 +25,9 @@
import org.apache.flink.configuration.description.Description;
import org.apache.flink.util.ArrayUtils;
+import org.apache.flink.shaded.guava18.com.google.common.base.Splitter;
+import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
Review comment:
Turns out people are fine with using more of guava now. 🤷♂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10816: [Flink-15355]
Fixed parsing of plugin parent-first patterns.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10816: [Flink-15355] Fixed parsing of plugin parent-first patterns.
URL: https://github.com/apache/flink/pull/10816#issuecomment-572581189
<!--
Meta data
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143738756 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:8f7604d34d7048aa46ec86671b43548f88369bb2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230 TriggerType:PUSH TriggerID:8f7604d34d7048aa46ec86671b43548f88369bb2
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:cb04c04cdb2cae6a8404e0bfce634f566cd1473c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143745165 TriggerType:PUSH TriggerID:cb04c04cdb2cae6a8404e0bfce634f566cd1473c
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:79f86e78791e0938480c97e422d7bc3003a97974 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143751586 TriggerType:PUSH TriggerID:79f86e78791e0938480c97e422d7bc3003a97974
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143764654 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
Hash:80ff3913aadd6719a43ba19a86068e8b50cc43f6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238 TriggerType:PUSH TriggerID:80ff3913aadd6719a43ba19a86068e8b50cc43f6
-->
## CI report:
* 8f7604d34d7048aa46ec86671b43548f88369bb2 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143738756) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4230)
* cb04c04cdb2cae6a8404e0bfce634f566cd1473c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143745165) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4231)
* 79f86e78791e0938480c97e422d7bc3003a97974 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143751586) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4232)
* 80ff3913aadd6719a43ba19a86068e8b50cc43f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143764654) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services