You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org> on 2006/11/18 23:10:37 UTC
[jira] Created: (JAMES-708) ImapHandler - unreachable code reached
ImapHandler - unreachable code reached
--------------------------------------
Key: JAMES-708
URL: http://issues.apache.org/jira/browse/JAMES-708
Project: James
Issue Type: Bug
Components: IMAPServer
Affects Versions: Trunk
Reporter: Robert Burrell Donkin
Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
When this happens, the log indicate that the code under this code:
theWatchdog.start();
while ( handleNextRequest(remoteHost, remoteIP) ) {
if (!handlerIsUp) {
getLogger().debug("Handler has been resetted");
return;
}
theWatchdog.reset();
}
// TODO is this unreachable code because of !handlerIsUp -> return?
getLogger().warn("Stopping watchdog after handling last request");
theWatchdog.stop();
is reached contrary to the TODO
(Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451995 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
sounds like a good plan
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451411 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
I've been running my local fork (pre-710) for a few hours with the connection timeout set to 0. No reoccurence as yet. Gut feeling tells me it's the timeout that's the issue so you can hold off that thinking for a while ;-)
Will report back later this week once I have more evidence
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-708) ImapHandler - unreachable code reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=all ]
Robert Burrell Donkin resolved JAMES-708.
-----------------------------------------
Resolution: Fixed
Think this has been resolved now.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451167 ]
Joachim Draeger commented on JAMES-708:
---------------------------------------
RFC 3501 require a minimum timeout of 30 minutes.
This should be configureable in config.xml and maybe this is already possible because of AbstractJamesService. :-)
At the moment I'm not sure if "java.net.SocketTimeoutException: Read timed out" is related to the configurable value. (There is a default of 5 minutes)
I'll have a deeper look after testing JAMES-710
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-708) ImapHandler - unreachable code reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=all ]
Robert Burrell Donkin updated JAMES-708:
----------------------------------------
Attachment: imap-timeout-warning.patch
The timeout is indeed configurable via the master setting. (Have rebuilt and will try post-710 per handler configuration later).
Here's a patch which improves disagnostics and warns users when the connection setting is set too low. I've ported to the post-710 code but haven't tested it locally yet.
Will report more later
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451078 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
Information from the logs:
from IMAP server log:
18/11/06 21:38:13 DEBUG imapserver: Calling reset() default Worker #8
18/11/06 21:38:46 DEBUG imapserver: Got <tag>: A00534
18/11/06 21:38:46 DEBUG imapserver: Got <command>: UID
18/11/06 21:38:46 DEBUG imapserver: Created command class org.apache.james.imapserver.commands.UidCommand
18/11/06 21:38:46 DEBUG imapserver: Created command class org.apache.james.imapserver.commands.StoreCommand
18/11/06 21:38:47 DEBUG imapserver: Calling reset() default Worker #8
18/11/06 21:38:48 WARN imapserver: Stopping watchdog after handling last request
18/11/06 21:38:48 DEBUG imapserver: Calling stop() default Worker #8
18/11/06 21:38:48 INFO imapserver: Connection for xxx from alpha.beta (nnn.nnn.nnn.nnn) closed.
18/11/06 21:38:48 DEBUG imapserver: Calling disposeWatchdog() default Worker #8
18/11/06 21:38:48 DEBUG imapserver: Returning a org.apache.james.imapserver.ImapHandler to the pool
18/11/06 21:38:48 DEBUG imapserver: Watchdog default Worker #8 is exiting run().
18/11/06 21:38:52 DEBUG imapserver: disposal
connections log around the same time:
18/11/06 21:28:35 DEBUG connections: Returning a org.apache.james.util.connection.ServerConnection$ClientConnectionRunner to the pool
18/11/06 21:29:02 DEBUG connections: Retrieving a org.apache.james.util.connection.ServerConnection$ClientConnectionRunner from the pool
18/11/06 21:29:02 DEBUG connections: Adding one connection for a total of 1
18/11/06 21:29:02 DEBUG connections: Starting connection on nnn.nnn.nnn.nnn:143 from nnn.nnn.nnn.nnn:32842
18/11/06 21:38:48 DEBUG connections: Ending connection on nnn.nnn.nnn.nnn:143 from nnn.nnn.nnn.nnn:32842
18/11/06 21:38:48 DEBUG connections: Releasing one connection, leaving a total of 0
18/11/06 21:38:48 DEBUG connections: Returning a org.apache.james.util.connection.ServerConnection$ClientConnectionRunner to the pool
18/11/06 21:38:51 DEBUG connections: Disposing server
no other logs have anything around that time
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451128 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
The log enabling patch gives more information:
19/11/06 07:57:53 DEBUG imapserver: Calling reset() default Worker #4
19/11/06 08:01:48 DEBUG imapserver: Watchdog default Worker #4 has time to sleep 300000
19/11/06 08:02:53 DEBUG imapserver: Error reading from stream
java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:129)
at java.net.SocketInputStream.read(SocketInputStream.java:182)
at org.apache.james.imapserver.debug.CopyInputStream.read(CopyInputStream.java:30)
at org.apache.james.imapserver.ImapRequestLineReader.nextChar(ImapRequestLineReader.java:89)
at org.apache.james.imapserver.ImapRequestHandler.handleRequest(ImapRequestHandler.java:68)
at org.apache.james.imapserver.ImapHandler.handleNextRequest(ImapHandler.java:297)
at org.apache.james.imapserver.ImapHandler.handleConnection(ImapHandler.java:244)
at org.apache.james.util.connection.ServerConnection$ClientConnectionRunner.run(ServerConnection.java:468)
at org.apache.excalibur.thread.impl.ExecutableRunnable.execute(ExecutableRunnable.java:55)
at org.apache.excalibur.thread.impl.WorkerThread.run(WorkerThread.java:116)
19/11/06 08:02:53 INFO imapserver: Cannot handling request:
org.apache.james.imapserver.ProtocolException: Error reading from stream.
at org.apache.james.imapserver.ImapRequestLineReader.nextChar(ImapRequestLineReader.java:96)
at org.apache.james.imapserver.ImapRequestHandler.handleRequest(ImapRequestHandler.java:68)
at org.apache.james.imapserver.ImapHandler.handleNextRequest(ImapHandler.java:297)
at org.apache.james.imapserver.ImapHandler.handleConnection(ImapHandler.java:244)
at org.apache.james.util.connection.ServerConnection$ClientConnectionRunner.run(ServerConnection.java:468)
at org.apache.excalibur.thread.impl.ExecutableRunnable.execute(ExecutableRunnable.java:55)
at org.apache.excalibur.thread.impl.WorkerThread.run(WorkerThread.java:116)
19/11/06 08:02:53 WARN imapserver: Stopping watchdog after handling last request
19/11/06 08:02:53 DEBUG imapserver: Calling stop() default Worker #4
The issue doesn't seem positively harmful but is annoying and reduces usability. IIRC IMAP specifies a long minimum auto-timeout. Wonder whether the socket's timeout is too low for IMAP compliance.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451126 ]
Joachim Draeger commented on JAMES-708:
---------------------------------------
What does "Server unexpectedly discounted: Success." mean? ;-)
Okay this part with the watchdog and the handler reset etc is tough.
It will deserve an entire code review. It is pretty much copy&paste from other components (POP3/SMTP) and James has changed here a lot since the imap-dev branch was disconnected.
I did only hacking here to get it to work.
ImapServer extends AbstractJamesService but ImapHandler is not extending AbstractJamesHandler.
AFAIK the most functionality is now in the abstract classes. So the best might be do do a rewrite of ImapServer and clean up ImapHandler.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451079 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
error message:
Error while scanning folders in 'IMAP server aaa.bbb' Server unexpectedly discounted: Success.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451170 ]
Stefano Bagnara commented on JAMES-708:
---------------------------------------
The code reported in this could be changed by JAMES-710 , I added !sessionEnded && handlerIsUp to the while, so that code will be always reached after the patch.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451458 ]
Robert Burrell Donkin commented on JAMES-708:
---------------------------------------------
The local fork with 710 seems stable with a long timeout.
With a short timeout, the client is effectively unusable but no errors :-/
Haven't had the original issue yet with 710 but IMAP is not stable for me without the timeout at least that stated in the spec.
May try per handler configuration later this week.
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-708) ImapHandler - unreachable code
reached
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-708?page=comments#action_12451661 ]
Joachim Draeger commented on JAMES-708:
---------------------------------------
Imap should be configured with the required timeouts (30 min.) by default.
The reference to the RFC in config.xml should be sufficient as a warning.
Let's see if the patch for JAMES-713 gets accepted soon.
If not, we need a solution to bumb up the socket timeout e.g. in
ImapHandler.initHandler()
> ImapHandler - unreachable code reached
> --------------------------------------
>
> Key: JAMES-708
> URL: http://issues.apache.org/jira/browse/JAMES-708
> Project: James
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Robert Burrell Donkin
> Attachments: imap-timeout-warning.patch
>
>
> Once in a while during normal operation, the client pops up a mysterious error message (will post next time it happens)
> When this happens, the log indicate that the code under this code:
> theWatchdog.start();
> while ( handleNextRequest(remoteHost, remoteIP) ) {
> if (!handlerIsUp) {
> getLogger().debug("Handler has been resetted");
> return;
> }
> theWatchdog.reset();
> }
> // TODO is this unreachable code because of !handlerIsUp -> return?
> getLogger().warn("Stopping watchdog after handling last request");
> theWatchdog.stop();
>
> is reached contrary to the TODO
> (Will add more logs and information)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org