You are viewing a plain text version of this content. The canonical link for it is here.
Posted to httpclient-users@hc.apache.org by Kenny MacLeod <ke...@kizoom.com> on 2008/10/17 13:02:52 UTC
ThreadSafeClientConnManager configuration example
Hi Folks,
I'm trying to find the least verbose way of configuring a
DefaultHttpClient with a ThreadSafeClientConnManager.
The example code given for this goes through a manual process of
configuring HttpParams and SchemeRegistry objects, which is more or less
copied from the DefaultHttpClient.createHttpParams() and
createClientConnectionManager() methods.
It's a bit of a chicken and egg situation - DefaultHttpClient can create
its own HttpParams and SchemeRegistry, which are themselves fine, but
only once its been constructed, and the constructor requires the
ThreadSafeClientConnManager, but that in turn requires the HttpParams
and SchemeRegistry objects. The only way out is to manually construct
the HttpParams and SchemeRegistry, which is a waste.
It seems to me that DefaultHttpClient's constructor should take a
ClientConnectionManagerFactory instead of a ClientConnectionManager.
That way, the createClientConnectionManager() method already has the
factory reference, and doesn't have to grub around in the HttpParams
object to find it.
The code would then become:
new DefaultHttpClient(new ThreadSafeClientConnManagerFactory(), null);
where ThreadSafeClientConnManagerFactory.newInstance() just constructs
ThreadSafeClientConnManager. There's no manual construction of
HttpParams and SchemeRegistry, you just leave it up to DefaultHttpClient.
Have I missed the point?
kenny
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org
Re: ThreadSafeClientConnManager configuration example
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2008-10-17 at 12:02 +0100, Kenny MacLeod wrote:
> Hi Folks,
>
> I'm trying to find the least verbose way of configuring a
> DefaultHttpClient with a ThreadSafeClientConnManager.
>
> The example code given for this goes through a manual process of
> configuring HttpParams and SchemeRegistry objects, which is more or less
> copied from the DefaultHttpClient.createHttpParams() and
> createClientConnectionManager() methods.
>
> It's a bit of a chicken and egg situation - DefaultHttpClient can create
> its own HttpParams and SchemeRegistry, which are themselves fine, but
> only once its been constructed, and the constructor requires the
> ThreadSafeClientConnManager, but that in turn requires the HttpParams
> and SchemeRegistry objects. The only way out is to manually construct
> the HttpParams and SchemeRegistry, which is a waste.
>
> It seems to me that DefaultHttpClient's constructor should take a
> ClientConnectionManagerFactory instead of a ClientConnectionManager.
> That way, the createClientConnectionManager() method already has the
> factory reference, and doesn't have to grub around in the HttpParams
> object to find it.
>
> The code would then become:
>
> new DefaultHttpClient(new ThreadSafeClientConnManagerFactory(), null);
>
> where ThreadSafeClientConnManagerFactory.newInstance() just constructs
> ThreadSafeClientConnManager. There's no manual construction of
> HttpParams and SchemeRegistry, you just leave it up to DefaultHttpClient.
>
> Have I missed the point?
>
> kenny
>
Makes sense. Feel free to open a change request in JIRA. However, we
will not be able to make this change until 4.1 I am afraid.
Oleg
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail: httpclient-users-help@hc.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org