You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/08/29 20:55:04 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
dongjoon-hyun opened a new pull request, #42727:
URL: https://github.com/apache/spark/pull/42727
### What changes were proposed in this pull request?
This PR aims to limit GHA job execution time to up to 5 hours in `build_and_test.yml`.
### Why are the changes needed?
Currently, the default value (6 hour) is used. However, when the jobs hit the limit, it's already a hung job and idle for up to 4 hours like the following.
- https://github.com/apache/spark/actions/runs/6006429750/job/16290982386
```
2023-08-29T02:05:37.2060361Z Finished test(python3.9): pyspark.sql.tests.connect.test_parity_udtf (121s) ... 6 tests were skipped
2023-08-29T02:05:37.2076438Z Starting test(python3.9): pyspark.sql.tests.connect.test_utils (temp output: /__w/spark/spark/python/target/23d2fd2f-b4c6-4427-a20d-e5c884298ed1/python3.9__pyspark.sql.tests.connect.test_utils__qirhbs_0.log)
2023-08-29T06:31:37.9787642Z ##[error]The operation was canceled.
2023-08-29T06:31:38.0274592Z ##[group]Run actions/upload-artifact@v3
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No because the successful CIs finished in 4 ~ 5 hours.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698460030
Thank you, @LuciferYang and @yaooqinn . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698434986
I am fine to add this config.
However, I think the key issue might be that it's currently very difficult for us to determine why a timeout has occurred, and I don't really have a good idea for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
URL: https://github.com/apache/spark/pull/42727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698367313
The default timeout minute is [360](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes). Is it necessary to only save one hour here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698423006
This is another incident in the yesterday commit log. Currently, we just hide this failure by simply re-triggering.
- https://github.com/apache/spark/actions/runs/6006429750/job/16290982386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698134418
cc @HyukjinKwon , @LuciferYang , @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698445205
Thank you, @LuciferYang . I've been looking at this issue.
- First, this PR will limit the timeout.
- Second, #42719 will split the long jobs (3~4 Python Connect Pandas Jobs) into smaller ones. Then, we can narrow down the issues more easily.
It will be tracked gradually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42727: [SPARK-45010][INFRA] Limit GHA job execution time to up to 5 hours in `build_and_test.yml`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42727:
URL: https://github.com/apache/spark/pull/42727#issuecomment-1698421543
Yes, it's because it's not a single pipeline. This PR applied to **26** pipelines per a commit and the timeout happens frequently in these day, @yaooqinn .
> The default timeout minute is [360](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes). Is it necessary to only save one hour here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org