[jira] [Commented] (HBASE-14129) If any regionserver gets shutdown uncleanly during full cluster restart, locality looks to be lost

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636052#comment-14636052 ] 

Hadoop QA commented on HBASE-14129:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12746416/HBASE-14129.patch
  against master branch at commit 5ec5552be0534dbf4b07ef6607741ae6f9ab0495.
  ATTACHMENT ID: 12746416

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14857//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14857//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14857//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14857//console

This message is automatically generated.

> If any regionserver gets shutdown uncleanly during full cluster restart, locality looks to be lost
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14129
>                 URL: https://issues.apache.org/jira/browse/HBASE-14129
>             Project: HBase
>          Issue Type: Bug
>            Reporter: churro morales
>         Attachments: HBASE-14129.patch
>
>
> We were doing a cluster restart the other day.  Some regionservers did not shut down cleanly.  Upon restart our locality went from 99% to 5%.  Upon looking at the AssignmentManager.joinCluster() code it calls AssignmentManager.processDeadServersAndRegionsInTransition().
> If the failover flag gets set for any reason it seems we don't call assignAllUserRegions().  Then it looks like the balancer does the work in assigning those regions, we don't use a locality aware balancer and we lost our region locality.
> I don't have a solid grasp on the reasoning for these checks but there could be some potential workarounds here.
> 1. After shutting down your cluster, move your WALs aside (replay later).  
> 2. Clean up your zNodes 
> That seems to work, but requires a lot of manual labor.  Another solution which I prefer would be to have a flag for ./start-hbase.sh --clean 
> If we start master with that flag then we do a check in AssignmentManager.processDeadServersAndRegionsInTransition()  thus if this flag is set we call: assignAllUserRegions() regardless of the failover state.
> I have a patch for the later solution, that is if I am understanding the logic correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)