[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2809: [GOBBLIN-960]Resolving multiple templates in top-level

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #2809: [GOBBLIN-960]Resolving multiple templates in top-level 
URL: https://github.com/apache/incubator-gobblin/pull/2809#discussion_r346982949
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/InheritingJobTemplate.java
 ##########
 @@ -75,23 +79,48 @@ private void resolveTemplates(Map<URI, JobTemplate> loadedTemplates) throws Spec
     if (this.resolved) {
       return;
     }
-    this.superTemplates = Lists.newArrayList();
-    for (URI uri : this.superTemplateUris) {
-      if (!loadedTemplates.containsKey(uri)) {
-        JobTemplate newTemplate = this.catalog.getTemplate(uri);
-        loadedTemplates.put(uri, newTemplate);
-        if (newTemplate instanceof InheritingJobTemplate) {
-          ((InheritingJobTemplate) newTemplate).resolveTemplates(loadedTemplates);
+
+    if (this.superTemplateUris.size() > 0) {
 
 Review comment:
   Added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services