You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/07/22 23:32:51 UTC

[GitHub] [incubator-pagespeed-mod] jmarantz commented on a change in pull request #1998: Several modernizations

jmarantz commented on a change in pull request #1998:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1998#discussion_r459141042



##########
File path: net/instaweb/rewriter/dedup_inlined_images_filter_test.cc
##########
@@ -39,10 +39,10 @@ namespace net_instaweb {
 namespace {
 
 // Filenames of resource files.
-const char kCuppaPngFilename[] = "Cuppa.png";
-const char kPuzzleJpgFilename[] = "Puzzle.jpg";
+constexpr absl::string_view kCuppaPngFilename = "Cuppa.png";

Review comment:
       Are these changes necessary? In the original code this gets initialized by the compiler. It's not obvious to me what happens in the new system; I"m surprised it compiles actually. When does the string_view ctor get run?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org