You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by ch...@locus.apache.org on 2000/06/02 19:23:08 UTC
cvs commit: modperl/src/modules/perl mod_perl.c
cholet 00/06/02 10:23:08
Modified: src/modules/perl mod_perl.c
Log:
fix segfault
Revision Changes Path
1.122 +1 -1 modperl/src/modules/perl/mod_perl.c
Index: mod_perl.c
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.c,v
retrieving revision 1.121
retrieving revision 1.122
diff -u -r1.121 -r1.122
--- mod_perl.c 2000/05/25 18:06:23 1.121
+++ mod_perl.c 2000/06/02 17:23:07 1.122
@@ -1222,7 +1222,7 @@
}
#ifdef CVf_METHOD
- if (CvFLAGS(cv) & CVf_METHOD) {
+ if (cv && (CvFLAGS(cv) & CVf_METHOD)) {
is_method = 1;
}
#endif
Re: cvs commit: modperl/src/modules/perl mod_perl.c
Posted by Doug MacEachern <do...@covalent.net>.
> I need some help explaining this change.
i would just call it:
fix for 'sub handler : method {}' support when method is not found
Re: cvs commit: modperl/src/modules/perl mod_perl.c
Posted by Eric Cholet <ch...@logilune.com>.
On Sat, Jun 03, 2000 at 01:57:26PM -0700, Ask Bjoern Hansen wrote:
> On 2 Jun 2000 cholet@locus.apache.org wrote:
>
> > Modified: src/modules/perl mod_perl.c
> > Log:
> > fix segfault
>
> Don't forget to update Changes.
>
I need some help explaining this change.
Here's what happened:
% cat >t/docs/Foo.pm
package foo;
sub handler { warn 'foo' }
1;
notice the typo, the package declaration says 'foo' instead of 'Foo'
% cat >>t/conf/httpd.conf
<Location /foo>
PerlHandler Foo
SetHandler perl-script
</Location>
GET /foo will trigger the segfault. Well, under 5.00502 it does, but under 5.6
I get an (expected) 500 internal server error.
--
Eric Cholet
Re: cvs commit: modperl/src/modules/perl mod_perl.c
Posted by Ask Bjoern Hansen <as...@valueclick.com>.
On 2 Jun 2000 cholet@locus.apache.org wrote:
> Modified: src/modules/perl mod_perl.c
> Log:
> fix segfault
Don't forget to update Changes.
- ask