You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/08/18 14:09:36 UTC
[GitHub] [zeppelin] milooy opened a new pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
milooy opened a new pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881
### What is this PR for?
**Before**
set sort type 'Number' but still sorted with string
After
Sorted with correct type
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-5002
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-675541232
Thanks for the contribution @milooy +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-695785789
@milooy I have merged it, feel free to create another ticket for the new UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-676471375
Thank @milooy for the fix!
[New UI implementation](https://github.com/apache/zeppelin/tree/master/zeppelin-web-angular) has the same problem. Could you apply this fix to the New UI as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-695785789
@milooy I have merged it, feel free to create another ticket for the new UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] milooy commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
milooy commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-727525005
Thx @zjffdu , Will make another ticket!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-693139670
ping @milooy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-682363623
ping @milooy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] milooy commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly
Posted by GitBox <gi...@apache.org>.
milooy commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-727535633
Guess it's already fixed in new UI 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org