You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "zhoulii (via GitHub)" <gi...@apache.org> on 2023/05/11 08:04:57 UTC
[GitHub] [incubator-streampark] zhoulii opened a new pull request, #2740: [FIX] enable token expire time
zhoulii opened a new pull request, #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740
## What changes were proposed in this pull request
enable token expire time which is unchangeable now.
## Verifying this change
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] enable token expire time [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys closed pull request #2740: [FIX] enable token expire time
URL: https://github.com/apache/incubator-streampark/pull/2740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #2740: [FIX] enable token expire time
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740#issuecomment-1546628317
set expiry time for tokens is not a good solution. A better way is for admin to be able to manually revoke tokens, which means the admin can make the token expire at any time. We can discuss how to implement this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] GOODBOY008 commented on pull request #2740: [FIX] enable token expire time
Posted by "GOODBOY008 (via GitHub)" <gi...@apache.org>.
GOODBOY008 commented on PR #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740#issuecomment-1543629251
> > It seems like disable expire time function manually. So I think if we confirm this function is useless and delete this function. @wolfboys @zhoulii cc.
>
> In my opinion, support token expire time is needed, I'm not sure why this function is disabled, maybe by accident ? 😂
So we need to dig the reason why disable date selector and set expire time to `9999-01-01` by default. Finally ,we discuss whether this fuction is need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FIX] enable token expire time [incubator-streampark]
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740#issuecomment-2002018001
resolved in version 2.1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] zhoulii commented on pull request #2740: [FIX] enable token expire time
Posted by "zhoulii (via GitHub)" <gi...@apache.org>.
zhoulii commented on PR #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740#issuecomment-1543597007
> It seems like disable expire time function manually. So I think if we confirm this function is useless and delete this function. @wolfboys @zhoulii cc.
In my opinion, support token expire time is needed, I'm not sure why this function is disabled, maybe by accident ? 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] GOODBOY008 commented on pull request #2740: [FIX] enable token expire time
Posted by "GOODBOY008 (via GitHub)" <gi...@apache.org>.
GOODBOY008 commented on PR #2740:
URL: https://github.com/apache/incubator-streampark/pull/2740#issuecomment-1543573978
It seems like disable expire time function manually. So I think if we confirm this function is useless and delete this function. @wolfboys @zhoulii cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org