You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/20 02:46:36 UTC
[GitHub] [kylin] zhaomoran opened a new pull request #1075: Bugfix statement
cache eviction invalidation base on time
zhaomoran opened a new pull request #1075: Bugfix statement cache eviction invalidation base on time
URL: https://github.com/apache/kylin/pull/1075
`minEvictableIdleTimeMillis ` param is invalid, because `timeBetweenEvictionRunsMillis ` parameter must be used at the same time. [GenericObjectPool](https://commons.apache.org/proper/commons-pool/api-1.6/org/apache/commons/pool/impl/GenericObjectPool.html)
```
timeBetweenEvictionRunsMillis indicates how long the eviction thread should sleep before "runs" of examining idle objects. When non-positive, no eviction thread will be launched. The default setting for this parameter is -1 (i.e., idle object eviction is disabled by default).
minEvictableIdleTimeMillis specifies the minimum amount of time that an object may sit idle in the pool before it is eligible for eviction due to idle time. When non-positive, no object will be dropped from the pool due to idle time alone. This setting has no effect unless timeBetweenEvictionRunsMillis > 0. The default setting for this parameter is 30 minutes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1075: KYLIN-4358:Bugfix
statement cache eviction invalidation base on time
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1075: KYLIN-4358:Bugfix statement cache eviction invalidation base on time
URL: https://github.com/apache/kylin/pull/1075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1075: Bugfix statement cache
eviction invalidation base on time
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1075: Bugfix statement cache eviction invalidation base on time
URL: https://github.com/apache/kylin/pull/1075#issuecomment-576089009
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=h1) Report
> Merging [#1075](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/43b248d807cea23c648b8cc730d94901f3635d42?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1075 +/- ##
============================================
- Coverage 25.06% 25.05% -0.01%
+ Complexity 6223 6222 -1
============================================
Files 1438 1438
Lines 87730 87731 +1
Branches 12257 12257
============================================
- Hits 21989 21981 -8
- Misses 63593 63599 +6
- Partials 2148 2151 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1075/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1075/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1075/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1075/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=footer). Last update [43b248d...b0941f1](https://codecov.io/gh/apache/kylin/pull/1075?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] zhaomoran commented on issue #1075: KYLIN-4358:Bugfix
statement cache eviction invalidation base on time
Posted by GitBox <gi...@apache.org>.
zhaomoran commented on issue #1075: KYLIN-4358:Bugfix statement cache eviction invalidation base on time
URL: https://github.com/apache/kylin/pull/1075#issuecomment-576092705
https://issues.apache.org/jira/browse/KYLIN-4358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1075: Bugfix statement cache
eviction invalidation base on time
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1075: Bugfix statement cache eviction invalidation base on time
URL: https://github.com/apache/kylin/pull/1075#issuecomment-576089048
## Pull Request Test Coverage Report for [Build 5542](https://coveralls.io/builds/28201742)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.51%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/28201742/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L183) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28201742/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/28201742/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L184) | 1 | 0% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28201742/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28201742/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/28201742) |
| :-- | --: |
| Change from base [Build 5537](https://coveralls.io/builds/28193424): | -0.006% |
| Covered Lines: | 24135 |
| Relevant Lines: | 87731 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services