[GitHub] [arrow-adbc] jorisvandenbossche opened a new pull request, #823: fix(c/driver/postgresql): Check if statement was released in stream reader

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche opened a new pull request, #823:
URL: https://github.com/apache/arrow-adbc/pull/823

   This came up experimenting in https://github.com/apache/arrow-adbc/pull/702. This patch seems to protect from segfaults when reading from a stream when the statement was already closed (`AdbcStatementRelease` was called). 
   Is that something we want to add? (and is it a proper way to achieve it?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on pull request #823: fix(c/driver/postgresql): Check if statement was released in stream reader

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on PR #823:
URL: https://github.com/apache/arrow-adbc/pull/823#issuecomment-1599099938

   I'm not sure this is worth doing; isn't it already a use-after-free? The fact that the memory happens to still be around is just a detail.
   
   Possibly the statement should track whether a stream is still open and prevent release instead (converting a use-after-free into a possible leak)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org