You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@serf.apache.org by James McCoy <ja...@debian.org> on 2018/10/24 03:20:41 UTC

[patch] create_certs.py compatibility with pyOpenSSL >= 17.1.0

Starting in 17.1.0, the OpenSSL.crypto.CRL.export() fuction requires the
caller to specify the digest type, after a few years of not specifying
one being a deprecation warning.  Since this is just used for tests, I
kept the old default of md5.

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

Re: [patch] create_certs.py compatibility with pyOpenSSL >= 17.1.0

Posted by Branko Čibej <br...@apache.org>.
On 26.10.2018 14:25, Branko Čibej wrote:
> On 24.10.2018 05:20, James McCoy wrote:
>> Starting in 17.1.0, the OpenSSL.crypto.CRL.export() fuction requires the
>> caller to specify the digest type, after a few years of not specifying
>> one being a deprecation warning.  Since this is just used for tests, I
>> kept the old default of md5.
> On the lastest macOS, which ships with Python 2.7.10 and pyopenssl 0.13.1:
>
> TypeError: 'digest' is an invalid keyword argument for this function
>
> But it works without the patch. This should be checking the version of
> pyopenssl, I think.

I committed a variant of this patch that supports both flavours of
PyOpenSSL in r1845542.

-- Brane


Re: [patch] create_certs.py compatibility with pyOpenSSL >= 17.1.0

Posted by Branko Čibej <br...@apache.org>.
On 24.10.2018 05:20, James McCoy wrote:
> Starting in 17.1.0, the OpenSSL.crypto.CRL.export() fuction requires the
> caller to specify the digest type, after a few years of not specifying
> one being a deprecation warning.  Since this is just used for tests, I
> kept the old default of md5.

On the lastest macOS, which ships with Python 2.7.10 and pyopenssl 0.13.1:

TypeError: 'digest' is an invalid keyword argument for this function

But it works without the patch. This should be checking the version of
pyopenssl, I think.

-- Brane