You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/01 11:48:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3265: arch: armv7-a: Fix memory corruption in SMP mode
xiaoxiang781216 commented on a change in pull request #3265:
URL: https://github.com/apache/incubator-nuttx/pull/3265#discussion_r605591560
##########
File path: arch/arm/src/armv7-a/arm_cpustart.c
##########
@@ -94,6 +118,10 @@ int arm_start_handler(int irq, FAR void *context, FAR void *arg)
sinfo("CPU%d Started\n", this_cpu());
+ /* Set IRQ mode stack for this CPU */
+
+ set_irqstack((uintptr_t)&g_irqtmp + (8 * this_cpu()));
Review comment:
why not move to arm_vectors.S
##########
File path: arch/arm/src/armv7-a/arm_cpustart.c
##########
@@ -94,6 +118,10 @@ int arm_start_handler(int irq, FAR void *context, FAR void *arg)
sinfo("CPU%d Started\n", this_cpu());
+ /* Set IRQ mode stack for this CPU */
+
+ set_irqstack((uintptr_t)&g_irqtmp + (8 * this_cpu()));
Review comment:
why not move to arm_vectors.S?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org