You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/05/05 11:02:06 UTC

[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4873: Snmp - added doc and refactor of the tests

JiriOndrusek opened a new pull request, #4873:
URL: https://github.com/apache/camel-quarkus/pull/4873

   follows https://github.com/apache/camel-quarkus/pull/4871
   
   Fixes all suggestion mentioned in https://github.com/apache/camel-quarkus/pull/4871#issuecomment-1535789390
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4873: Snmp - added doc and refactor of the tests

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4873:
URL: https://github.com/apache/camel-quarkus/pull/4873#issuecomment-1539529743

   @ppalaga thank you for the fixes you provided!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4873: Snmp - added doc and refactor of the tests

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4873:
URL: https://github.com/apache/camel-quarkus/pull/4873#issuecomment-1536087529

   I added the text into limitations section, as it feels like the right one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #4873: Snmp - added doc and refactor of the tests

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4873:
URL: https://github.com/apache/camel-quarkus/pull/4873#issuecomment-1536361813

   @JiriOndrusek thanks for adressing the suggestions!
   
   I dared to fixup some small glitches in this PR by creating a new PR to avoid another review round: https://github.com/apache/camel-quarkus/pull/4876
   
   First, `snm` in the `org.apache.camel.quarkus.component.snm.graal` package name looked like a typo. I changed it to simply `org.apache.camel.quarkus.component.snmp` because we tend to use graal packages for substitutions. I also moved the camel classes to `org.apache.camel.quarkus.component.snmp` because I think there is no reason to introduce a duplicate package. 
   Other than that, i rephrased the docs text a bit. I hope I have not broken anything. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga closed pull request #4873: Snmp - added doc and refactor of the tests

Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga closed pull request #4873: Snmp - added doc and refactor of the tests
URL: https://github.com/apache/camel-quarkus/pull/4873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org