You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/19 15:59:08 UTC
[GitHub] codecov-io commented on issue #459: SCB-953 Make clusters
configuration convenient
codecov-io commented on issue #459: SCB-953 Make clusters configuration convenient
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/459#issuecomment-431412295
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=h1) Report
> Merging [#459](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3fe59edb7c6de5c58fb19aeb7b29a1158124e03e?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 60.1% 60.16% +0.05%
==========================================
Files 156 156
Lines 13414 13414
==========================================
+ Hits 8063 8071 +8
+ Misses 4770 4762 -8
Partials 581 581
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
| [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (+0.56%)` | :arrow_up: |
| [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=footer). Last update [3fe59ed...48260c7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/459?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services