[GitHub] [incubator-pinot] tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues

[GitBox <gi...@apache.org>]

tangdian commented on a change in pull request #4113: [TE] Fix MySQL and H2 timestamp automatic timezone conversion issues
URL: https://github.com/apache/incubator-pinot/pull/4113#discussion_r275861143
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/sql/SqlThirdEyeDataSource.java
 ##########
 @@ -45,11 +45,13 @@
   private static final ThirdEyeCacheRegistry CACHE_REGISTRY_INSTANCE = ThirdEyeCacheRegistry.getInstance();
   protected LoadingCache<RelationalQuery, ThirdEyeResultSetGroup> sqlResponseCache;
   private SqlResponseCacheLoader sqlResponseCacheLoader;
-  public static final String DATA_SOURCE_NAME = SqlThirdEyeDataSource.class.getSimpleName();
-
+  private String serverTimezone = "UTC";
 
 
   public SqlThirdEyeDataSource(Map<String, Object> properties) throws Exception {
+    if (properties.containsKey("serverTimezone")) {
 
 Review comment:
   Good to know! I didn't realize there is a way to get local time zone. I will be using DateTimeZone.getDefault().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org