You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/16 06:00:32 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #794: Feat/dubbo gen stream support
LaurenceLiZhixin opened a new pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794
**What this PR does**:
增加了dubbo-gen的stream类型支持
**Which issue(s) this PR fixes**:
**Special notes for your reviewer**:
修改了grpc/protoc-gen-dubbo/dubbo/dubbo.go内关于stream类型的pb.go文件生成。
主要修改了grpc.StreamDesc{}结构关于stream类型的服务发现支持。
可直接使用grpc提供的stream服务达到客户端与服务端交互的目的
**Does this PR introduce a user-facing change?**:
NONE
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #794: [Ftr]: dubbo-gen stream support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794#issuecomment-709904529
>
>
> Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples
Of course, I'll do it right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #794: [Ftr]: dubbo-gen stream support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794#issuecomment-709940817
>
>
> Should you provide a sample for grpc stream in https://github.com/apache/dubbo-go-samples
I create a sample pr at : https://github.com/apache/dubbo-go-samples/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #794: Feat/dubbo gen stream support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794#issuecomment-709822538
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=h1) Report
> Merging [#794](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f4c03f70e48e8814b35e6fe29272bc4e88ff7999?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #794 +/- ##
===========================================
- Coverage 59.91% 59.80% -0.12%
===========================================
Files 259 259
Lines 12737 12751 +14
===========================================
- Hits 7632 7626 -6
- Misses 4152 4172 +20
Partials 953 953
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/794/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <57.14%> (+9.98%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/794/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/794/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/794/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `46.51% <0.00%> (-4.66%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/794/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=footer). Last update [0780dcf...8722856](https://codecov.io/gh/apache/dubbo-go/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #794: [Ftr]: dubbo-gen stream support
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #794: [Ftr]: dubbo-gen stream support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #794:
URL: https://github.com/apache/dubbo-go/pull/794#issuecomment-710717807
hi @xujianhai666 , pls review this pr. thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org