[GitHub] [hive] belugabehr commented on pull request #2303: Add NoReconnect Annotation to CreateXXX Methods With AlreadyExistsException

[GitBox <gi...@apache.org>]

belugabehr commented on pull request #2303:
URL: https://github.com/apache/hive/pull/2303#issuecomment-846027218


   @nrg4878 I have changed the title of the PR.  It's not about _creating_ the exception.  I've added the annotation to any createXXX method which also throws an AlreadyExistsException.  It does not make sense to re-try these methods because you could be in a situation where the operation completes from the perspective of HMS but the connection is killed and then a "AlreadyExists" exception is thrown which is very confusing from the client perspective.  Best to just throw an error and have the client software decide how to handle it.
   
   re: Annotation inheritance, I'll double-check, but there already exists one on this interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org