You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/18 08:12:34 UTC
[GitHub] [incubator-inlong] chestnut-c opened a new pull request #2581: [INLONG-2579][Manager] support data flow to ClickHouse
chestnut-c opened a new pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581
### Title Name: [INLONG-2579][Manager] support data flow to ClickHouse
Fixes #2579
### Motivation
* InLong Manager support data flow to ClickHouse
### Modifications
* add clickhouse storage type in InLong Manager
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] chestnut-c commented on a change in pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
chestnut-c commented on a change in pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581#discussion_r810453533
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizConstant.java
##########
@@ -24,6 +24,8 @@
public static final String STORAGE_HIVE = "HIVE";
+ public static final String STORAGE_CLICKHOUSE = "CLICKHOUSE";
Review comment:
When the function is written, optimize it together next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581#discussion_r810437386
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizConstant.java
##########
@@ -24,6 +24,8 @@
public static final String STORAGE_HIVE = "HIVE";
+ public static final String STORAGE_CLICKHOUSE = "CLICKHOUSE";
Review comment:
there are several storage classes, can we manage them using a `storage enum`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] chestnut-c commented on a change in pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
chestnut-c commented on a change in pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581#discussion_r810454731
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizConstant.java
##########
@@ -24,6 +24,8 @@
public static final String STORAGE_HIVE = "HIVE";
+ public static final String STORAGE_CLICKHOUSE = "CLICKHOUSE";
Review comment:
ok ,i will to change it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] chestnut-c commented on a change in pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
chestnut-c commented on a change in pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581#discussion_r810454731
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizConstant.java
##########
@@ -24,6 +24,8 @@
public static final String STORAGE_HIVE = "HIVE";
+ public static final String STORAGE_CLICKHOUSE = "CLICKHOUSE";
Review comment:
ok ,i am willing to change it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] chestnut-c commented on a change in pull request #2581: [INLONG-2579][Manager] Support data flow to ClickHouse
Posted by GitBox <gi...@apache.org>.
chestnut-c commented on a change in pull request #2581:
URL: https://github.com/apache/incubator-inlong/pull/2581#discussion_r810453533
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/BizConstant.java
##########
@@ -24,6 +24,8 @@
public static final String STORAGE_HIVE = "HIVE";
+ public static final String STORAGE_CLICKHOUSE = "CLICKHOUSE";
Review comment:
When the function is written, optimize it together next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org