You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gilv <gi...@git.apache.org> on 2015/10/14 13:07:00 UTC
[GitHub] couchdb pull request: COUCHDB-769: Store attachments in the extern...
GitHub user gilv opened a pull request:
https://github.com/apache/couchdb/pull/361
COUCHDB-769: Store attachments in the external storage
Initial implementation that allows CouchDB to store attachments outside of the database file.
This implementation supports OpenStack Swift and SoftLayer Object store.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gilv/couchdb store_attachments_external
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 8b0567edc30a1151621fecf917c1161d652eae8a
Author: Gil Vernik <gi...@il.ibm.com>
Date: 2015-10-14T10:38:17Z
COUCHDB-769: Store attachments in external storage. This is initial implementation, supports OpenStack Swift and SoftLayer Object store
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-769: Store attachments in the extern...
Posted by gilv <gi...@git.apache.org>.
Github user gilv commented on the pull request:
https://github.com/apache/couchdb/pull/361#issuecomment-167116424
@rnewson i got it... it was my mistake, when i did git pull..
so my question now is : is it fine that it shows 25 commits when actually i have only one here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-769: Store attachments in the extern...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb/pull/361#issuecomment-148041826
noting here that we shouldn't merge this work (or any new significant feature work) before 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-769: Store attachments in the extern...
Posted by gilv <gi...@git.apache.org>.
Github user gilv commented on the pull request:
https://github.com/apache/couchdb/pull/361#issuecomment-167115435
@rnewson : i updated master branch, then merged it with my branch and pushed the changes.
It seems the merge is a bit weird.. can you explain me what i did wrong?
Here is what i did:
git remote -v
origin https://github.com/gilv/couchdb.git (fetch)
origin https://github.com/gilv/couchdb.git (push)
upstream https://github.com/apache/couchdb.git (fetch)
upstream https://github.com/apache/couchdb.git (push)
git checkout master
git pull upstream master
git push
git checkout store_attachments_external
git fetch origin
git merge origin/master
when i did:
git push origin store_attachments_external - there was an error that i should pull before.
so i did:
git pull origin store_attachments_external
and then
git push origin store_attachments_external
Now i see that something is wrong and there are commits that has nothing to do to my code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-769: Store attachments in the extern...
Posted by gilv <gi...@git.apache.org>.
Github user gilv commented on the pull request:
https://github.com/apache/couchdb/pull/361#issuecomment-168609353
@kxepal @rnewson
I provided another patch, implementing most of the comments.
Here is what is not implemented in this patch:
1. Remark on the AttFun. Not yet implemented. Original remark: “AttFun could be actually an attachment data or some fold function? Something went wrong if you have to do this.”
2. usage of couch_util:to_hex
3. still no unitests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb issue #361: COUCHDB-769: Store attachments in the external storage
Posted by wohali <gi...@git.apache.org>.
Github user wohali commented on the issue:
https://github.com/apache/couchdb/pull/361
Hi @rnewson and @davisp , is this affected at all by the pluggable storage engine work? (I'm guessing it might very well be.) If not, could we consider merging it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---