You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ga...@apache.org on 2017/01/22 06:02:17 UTC
kylin git commit: KYLIN-2412 Unclosed DataOutputStream in
RoaringBitmapCounter#write()
Repository: kylin
Updated Branches:
refs/heads/master 7576a09f2 -> d264339b1
KYLIN-2412 Unclosed DataOutputStream in RoaringBitmapCounter#write()
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/d264339b
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/d264339b
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/d264339b
Branch: refs/heads/master
Commit: d264339b1c16c195ffafc2217b793d81bdbd6434
Parents: 7576a09
Author: gaodayue <ga...@meituan.com>
Authored: Sun Jan 22 14:02:09 2017 +0800
Committer: gaodayue <ga...@meituan.com>
Committed: Sun Jan 22 14:02:09 2017 +0800
----------------------------------------------------------------------
.../org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/d264339b/core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java b/core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java
index cd07d20..fb9dcfc 100644
--- a/core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java
+++ b/core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RoaringBitmapCounter.java
@@ -107,7 +107,9 @@ public class RoaringBitmapCounter implements BitmapCounter {
if (out.remaining() < bitmap.serializedSizeInBytes()) {
throw new BufferOverflowException();
}
- bitmap.serialize(new DataOutputStream(new ByteBufferOutputStream(out)));
+ try (DataOutputStream dos = new DataOutputStream(new ByteBufferOutputStream(out))) {
+ bitmap.serialize(dos);
+ }
}
@Override