[jira] [Comment Edited] (OAK-2833) Refactor TarMK

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560848#comment-14560848 ] 

Michael Dürig edited comment on OAK-2833 at 11/27/15 1:21 PM:
--------------------------------------------------------------

We need to be careful going forward here in order not to break anything as this is pretty much open heart surgery. Also we need take to be careful wrt. to maintainability of our branches. The suggest approach is to break this apart into smaller incremental improvements where each improvement would first increase test coverage for the refactored part, do the refactoring and then merge it back to the branches. 

IMO a good place to start is to break up the {{SegmentWriter}} (see OAK-1828). Based on the experience gathered we should then follow up with introducing dual concepts for reading from segments instead of doing this ad-hoc and inline all over the places. 

cc [~alex.parvulescu], [~egli]


was (Author: mduerig):
We need to be careful going forward here in order not to break anything as this is pretty much open hear surgery. Also we need take to be careful wrt. to maintainability of our branches. The suggest approach is to break this apart into smaller incremental improvements where each improvement would first increase test coverage for the refactored part, do the refactoring and then merge it back to the branches. 

IMO a good place to start is to break up the {{SegmentWriter}} (see OAK-1828). Based on the experience gathered we should then follow up with introducing dual concepts for reading from segments instead of doing this ad-hoc and inline all over the places. 

cc [~alex.parvulescu], [~egli]

> Refactor TarMK
> --------------
>
>                 Key: OAK-2833
>                 URL: https://issues.apache.org/jira/browse/OAK-2833
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: 1.4
>
>
> Container issue for refactoring the TarMK to make it more testable, maintainable, extensible and less entangled. 
> For example the segment format should be readable, writeable through standalone means so tests, tools and production code can share this code. Currently there is a lot of code duplication involved here. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)