[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

["Arun Suresh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303920#comment-16303920 ] 

Arun Suresh commented on YARN-7682:
-----------------------------------

Thanks for the patch [~pgaref]..

bq. We also have the delayedOr special case that should be taken into account at this level I believe
I think we should ignore Delayed or for the time being. My initial thought was that we should pass in the placementAttempt and timestamp of the last placed-attempt into the canAssign. This way, the canAssign can choose which Constraint can be chosen from within the list of delayed-or PlacementConstraint. But lets tackle that later, once we get the end2end for SingleConstraints working correctly.

You have a TODO there that states that it currently works only for anti-affinity.
I think we can do affinity, anti-affinity and cardinality right ? For the time-being, lets just transform everything using the SingleConstraintTransformer into a SingleConstraint - since we can express targetIn, targetNotIn and cardinality using SingleConstraint. and then check if the constraint is violated or not. [~kkaranasos], thoughts ?






> Expose canAssign method in the PlacementConstraintManager
> ---------------------------------------------------------
>
>                 Key: YARN-7682
>                 URL: https://issues.apache.org/jira/browse/YARN-7682
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Panagiotis Garefalakis
>         Attachments: YARN-7682.wip.patch
>
>
> As per discussion in YARN-7613. Lets expose {{canAssign}} method in the PlacementConstraintManager that takes a sourceTags, applicationId, SchedulerNode and AllocationTagsManager and returns true if constraints are not violated by placing the container on the node.
> I prefer not passing in the SchedulingRequest, since it can have > 1 numAllocations. We want this api to be called for single allocations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org