You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Varun Vasudev (JIRA)" <ji...@apache.org> on 2016/08/22 14:46:20 UTC
[jira] [Comment Edited] (YARN-3998) Add support in the NodeManager
to re-launch containers
[ https://issues.apache.org/jira/browse/YARN-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430896#comment-15430896 ]
Varun Vasudev edited comment on YARN-3998 at 8/22/16 2:46 PM:
--------------------------------------------------------------
Thanks for the comment Jason!
bq. I believe the old software will ignore unrecognized keys in the state store, so we may be OK with a rolling downgrade as long as the resulting behavior is expected
I think that's not the case. From {code}NMLeveldbStateStoreService#loadContainerState{code}, it looks like we throw an exception when we encounter a field we don't know of.
{code}
} else {
throw new IOException("Unexpected container state key: " + key);
}
{code}
Should we file a ticket to get this changed?
The rest of your comment makes sense - I don't see any reason to flag this as an incompatible change. Just to clarify - we only write re-launch data if re-launch is requested - so as long as end users are not using the feature - they can upgrade and downgrade without any issues.
was (Author: vvasudev):
Thanks for the comment Jason!
bq. I believe the old software will ignore unrecognized keys in the state store, so we may be OK with a rolling downgrade as long as the resulting behavior is expected
I think that's not the case. From {code}NMLeveldbStateStoreService#loadContainerState{code}, it looks like we throw an exception when we encounter a field we don't know of.
{code}
} else {
throw new IOException("Unexpected container state key: " + key);
}
{code}
Should we file a ticket to get this changed?
The rest of your comment makes sense - I don't see any reason to flag this as an incompatible change.
> Add support in the NodeManager to re-launch containers
> ------------------------------------------------------
>
> Key: YARN-3998
> URL: https://issues.apache.org/jira/browse/YARN-3998
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jun Gong
> Assignee: Jun Gong
> Fix For: 2.9.0
>
> Attachments: YARN-3998.01.patch, YARN-3998.02.patch, YARN-3998.03.patch, YARN-3998.04.patch, YARN-3998.05.patch, YARN-3998.06.patch, YARN-3998.07.patch, YARN-3998.08.patch, YARN-3998.09.patch
>
>
> I'd like to add a field(retry-times) in ContainerLaunchContext. When AM launches containers, it could specify the value. Then NM will re-launch the container 'retry-times' times when it fails to run(e.g.exit code is not 0).
> It will save a lot of time. It avoids container localization. RM does not need to re-schedule the container. And local files in container's working directory will be left for re-use.(If container have downloaded some big files, it does not need to re-download them when running again.)
> We find it is useful in systems like Storm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org