You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2020/05/05 19:24:01 UTC
[hbase] branch branch-2.1 updated: HBASE-24322 UnsafeAvailChecker
should also check that required methods are available (#1650)
This is an automated email from the ASF dual-hosted git repository.
apurtell pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new fea4e4f HBASE-24322 UnsafeAvailChecker should also check that required methods are available (#1650)
fea4e4f is described below
commit fea4e4f12e51ff961006c44e5c29fd4435cade76
Author: Andrew Purtell <ap...@apache.org>
AuthorDate: Tue May 5 12:07:56 2020 -0700
HBASE-24322 UnsafeAvailChecker should also check that required methods are available (#1650)
Signed-off-by: Viraj Jasani <vj...@apache.org>
Signed-off-by: Anoop Sam John <an...@apache.org>
---
.../hadoop/hbase/util/UnsafeAvailChecker.java | 100 ++++++++++++++++++++-
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java
index 88dd524..1213c3c 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java
@@ -42,7 +42,105 @@ public class UnsafeAvailChecker {
Class<?> clazz = Class.forName(CLASS_NAME);
Field f = clazz.getDeclaredField("theUnsafe");
f.setAccessible(true);
- return f.get(null) != null;
+ Object theUnsafe = f.get(null);
+ if (theUnsafe == null) {
+ LOG.warn("Could not get static instance from sun.misc.Unsafe");
+ return false;
+ }
+ // Check for availability of all methods used by UnsafeAccess
+ Method m;
+ try {
+ m = clazz.getDeclaredMethod("arrayBaseOffset", Class.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing arrayBaseOffset(Class)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("copyMemory", Object.class, long.class, Object.class,
+ long.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing copyMemory(Object,long,Object,long,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getByte", Object.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getByte(Object,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getShort", long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getShort(long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getShort", Object.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getShort(Object,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getInt", long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getInt(long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getInt", Object.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getInt(Object,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getLong", long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getLong(long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("getLong", Object.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing getLong(Object,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putByte", long.class, byte.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putByte(long,byte)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putByte", Object.class, long.class, byte.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putByte(Object,long,byte)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putShort", long.class, short.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putShort(long,short)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putShort", Object.class, long.class, short.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putShort(Object,long,short)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putInt", long.class, int.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putInt(long,int)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putInt", Object.class, long.class, int.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putInt(Object,long,int)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putLong", long.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putLong(long,long)");
+ return false;
+ }
+ m = clazz.getDeclaredMethod("putLong", Object.class, long.class, long.class);
+ if (m == null) {
+ LOG.warn("sun.misc.Unsafe is missing putLong(Object,long,long)");
+ return false;
+ }
+ // theUnsafe is accessible and all methods are available
+ return true;
+ } catch (Throwable e) {
+ LOG.warn("sun.misc.Unsafe is missing one or more required methods", e);
+ }
} catch (Throwable e) {
LOG.warn("sun.misc.Unsafe is not available/accessible", e);
}