You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/03 11:18:52 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5748: Allow null values on Vmware appliances details
nvazquez opened a new pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748
### Description
This PR allows deploying VMware appliances missing default values on some properties
Fixes: #5747
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Register template missing default values on some properties using 'Read Settings from OVA' = true
- Deploy VM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5748: Allow null values on Vmware appliances details
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985437424
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r770573946
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
> @nvazquez Ok, In case VMware expects keys with empty values. Have you tested without the keys?
@nvazquez Have you tested without the keys (instead of keys with empty values) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985953479
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r764550243
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
@nvazquez Ok, In case VMware expects keys with empty values. Have you tested without the keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985952808
Thanks @sureshanaparti, have refactored the PR
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-986040418
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Allow null values on Vmware appliances details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985438151
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5748: Allow null values on Vmware appliances details
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985491403
@nvazquez can the detail be considered as null when it doesn't exist in the table, or use empty instead of null. this way, the details table is inline with other details table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985952942
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-986040376
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-986438334
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r762968886
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
how about not adding the key/value to map `userVmOVFPropertiesMap` when the value is null or empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5748: Allow null values on Vmware appliances details
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985491403
@nvazquez can the 'deploy-as-is' detail be considered as null when it doesn't exist in the table, or use empty instead of null. this way, the details table is inline with other details table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r762930018
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
@nvazquez does this require special handling in the vmware resource/- guru? I mean to make sure vmware get the right type of value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985952942
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Allow null values on Vmware appliances details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985465878
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985953636
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-986438613
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-985963244
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#issuecomment-986841129
<b>Trillian test result (tid-2620)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33967 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5748-t2620-vmware-67u3.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r764526276
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
This could cause the deployments to fail as Vmware will expect some keys even with empty values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5748: Prevent null values on Vmware appliances details that are missing a default value
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5748:
URL: https://github.com/apache/cloudstack/pull/5748#discussion_r778313103
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4399,6 +4399,8 @@ private void persistVMDeployAsIsProperties(UserVmVO vm, Map<String, String> user
value = DBEncryptionUtil.encrypt(value);
}
}
+ } else if (value == null) {
+ value = "";
Review comment:
Sorry @sureshanaparti I was on leave, no. Have not tested without the keys, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org