[jira] [Commented] (KAFKA-254) A tool to GET Zookeeper partition-offset and output to files

["Jun Rao (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199458#comment-13199458 ] 

Jun Rao commented on KAFKA-254:
-------------------------------

Thanks for the patch. A few comments:
1. For consistency, let's use joptsimple for command line processing (take a look at some other tools as examples).
2. We should use ZkClient, instead of the raw ZK client (see ConsumerOffsetChecker)
3. Could we extend this to support multiple consumer groups? We can use an option --groups to specify all groups. If the option is not specified, we can get all groups registered in ZK. We will need to include group name in the output file.
4. Use the zk common paths already defined in ZkUtils.

Those comments are applicable to kafka-255 too.
                
> A tool to GET Zookeeper partition-offset and output to files
> ------------------------------------------------------------
>
>                 Key: KAFKA-254
>                 URL: https://issues.apache.org/jira/browse/KAFKA-254
>             Project: Kafka
>          Issue Type: Task
>          Components: clients
>            Reporter: John Fung
>            Assignee: John Fung
>         Attachments: kafka-254-v1.patch
>
>
> A utility that retrieves the offsets of all topic partitions in ZK for a specified group id and save the data to output files. A shell script also comes with this tool to automate the writing of data to files in a specified time interval.
> This utility expects 3 arguments:
>  1. Zk host:port string
>  2. group Id
>  3. Output file pathname

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira