You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/04/10 09:49:46 UTC

[GitHub] [groovy] pbielicki commented on a change in pull request #1552: GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…

pbielicki commented on a change in pull request #1552:
URL: https://github.com/apache/groovy/pull/1552#discussion_r611023878



##########
File path: src/test/groovy/StringTest.groovy
##########
@@ -241,6 +241,11 @@ foo
 
         text = $/$$$$$//$
         assert text == '$$/'
+
+        //GROOVY-10024
+        def s1 = $/abc\/$
+        def s2 = $/def/$
+        assert s1.size() == 4 && s2.size() == 3

Review comment:
       I’d assert the expected values instead of the size.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org