You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jan Bareš (JIRA)" <ji...@apache.org> on 2007/04/27 13:41:15 UTC
[jira] Created: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation is broken
New ServletWebRequest.getParameterMap() implementation is broken
----------------------------------------------------------------
Key: WICKET-511
URL: https://issues.apache.org/jira/browse/WICKET-511
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.2.6
Reporter: Jan Bareš
Priority: Critical
The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
return new HashMap(httpServletRequest.getParameterMap());
According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation is broken
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492305 ]
Gwyn Evans commented on WICKET-511:
-----------------------------------
Well, it's now "doing the right thing", but as a matter of policy, had we realised that we were changing the value type, we'd almost certainly not have applied it to 1.2.6 in the same way.
It would have still been applied to 1.3, though! It's "intended behaviour" there but not for 1.2.6 /purely/ because in a 1.2.x release, we make efforts not to change the API, which /does/ restrict us as to what changes are applied.
> New ServletWebRequest.getParameterMap() implementation is broken
> ----------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Trivial
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation changed between 1.2.5
and 1.2.6
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-511:
--------------------------------
Fix Version/s: 1.2.7
Summary: New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6 (was: New ServletWebRequest.getParameterMap() implementation is broken)
> New ServletWebRequest.getParameterMap() implementation changed between 1.2.5 and 1.2.6
> --------------------------------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Trivial
> Fix For: 1.2.7
>
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation is broken
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492297 ]
Johan Compagner commented on WICKET-511:
----------------------------------------
so we now follow the spec and now we think it is broken???
we can rollback it for 1.2 but i guess for 1.3 we keep it what it is now. Because it should return String,String[] ....
> New ServletWebRequest.getParameterMap() implementation is broken
> ----------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Trivial
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation is broken
Posted by "Jan Bareš (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Bareš updated WICKET-511:
-----------------------------
Priority: Trivial (was: Critical)
Aha, I should call PageParameters.getString() instead of get(). So maybe this is intended behaviour. Please clarify and close.
> New ServletWebRequest.getParameterMap() implementation is broken
> ----------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Trivial
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-511) New
ServletWebRequest.getParameterMap() implementation is broken
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492290 ]
Gwyn Evans commented on WICKET-511:
-----------------------------------
Looks like it was WICKET-291 that changed it - although I doubt it was appreciated then that 1.2.x was 'broken' and this 'fixed' it...
> New ServletWebRequest.getParameterMap() implementation is broken
> ----------------------------------------------------------------
>
> Key: WICKET-511
> URL: https://issues.apache.org/jira/browse/WICKET-511
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.6
> Reporter: Jan Bareš
> Priority: Critical
>
> The implementation of ServletWebRequest.getParameterMap() changed between 1.2.5 and 1.2.6. Now it simply calls:
> return new HashMap(httpServletRequest.getParameterMap());
> According to Servlet specification, ServletRequest.getParameterMap() returns map of <String, String[]>. Please note that the value is *array* of Strings. The new implementation of ServletWebRequest.getParameterMap() is now broken, because in 1.2.5 it returned "Map<String, String>".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.