You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/06 01:03:32 UTC
[GitHub] [iceberg] samredai opened a new pull request #3479: Add a How To Vote page
samredai opened a new pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479
This adds a page in the `Project` section on "How to Vote" that covers the tests at a high level. @kbendick mentioned that testing will become more intricate in the future so I think a more comprehensive "How to Test" page is called for and we can link to it from the page that covers the voting process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753384923
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
Review comment:
Ah nice, I didn't realize the link always stays the same. Updated to use a curl command. đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751501601
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
Review comment:
The `KEYS` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751504216
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+### Verifying Checksums
+
+```bash
+shasum -a 512 apache-iceberg-${VERSION}.tar.gz.sha512
+```
+
+### Verifying License Documentation
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+### Verifying Build and Test
+
+To verify that the release candidate builds properly, run the following command.
+```bash
+./gradlew build
+```
+
+## Testing release binaries
+
+Release announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!! Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+### Verifying with Spark
+
+To verify using spark, start a `spark-shell` with a command like the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+### Verifying with Flink
+
+To verify using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Voting
+Votes are cast by replying to the release candidate announcement email on the dev mailing list
Review comment:
Nit: missing a newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r748911302
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+## Verifying with Flink
+
+To verify a candidate using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Announcement Content
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+## Verifying Signatures
Review comment:
Can you make these one level under the source or binary headings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315538
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
+```bash
+./gradlew build
+```
+
+Votes are cast by replying to the release candidate announcement email on the dev mailing list
+with either +1, 0, or -1.
+
+> [ ] +1 Release this as Apache Iceberg ${VERSION}
+[ ] +0
+[ ] -1 Do not release this because...
+
+In addition to your vote, it's customary to specify if your vote is binding or non-binding. Only members
+of the Project Management Committee have formally binding votes. If you're unsure, you can specify that your
+vote is non-binding. To read more about voting in the Apache framework, checkout the
+[Voting](https://www.apache.org/foundation/voting.html) information page on the Apache foundation's website.
Review comment:
Could you also add a section on adding the candidate's maven repository to downstream builds? We always supply the maven repository location so that people can add the repository to maven or gradle and test downstream projects easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751311848
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
Review comment:
Agreed, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753580864
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,151 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# How to Verify a Release
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **KEYS file**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and KEYS file, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS
+gpg --import KEYS
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-{{ extra.versions.iceberg }}.tar.gz.asc
+```
+
+### Verifying Checksums
+
+```bash
+shasum -a 512 apache-iceberg-{{ extra.versions.iceberg }}.tar.gz.sha512
+```
+
+### Verifying License Documentation
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
Review comment:
`extra.versions.iceberg` here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744047777
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
No you're right, it doesn't exist by default on mac, you have to install coreutils. I'll make a note of that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r746581152
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
Updated to use the `shasum -a 512` command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753384277
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+### Verifying Checksums
+
+```bash
+shasum -a 512 apache-iceberg-${VERSION}.tar.gz.sha512
+```
+
+### Verifying License Documentation
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+### Verifying Build and Test
+
+To verify that the release candidate builds properly, run the following command.
+```bash
+./gradlew build
+```
+
+## Testing release binaries
+
+Release announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!! Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+### Verifying with Spark
+
+To verify using spark, start a `spark-shell` with a command like the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+### Verifying with Flink
+
+To verify using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Voting
+Votes are cast by replying to the release candidate announcement email on the dev mailing list
Review comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744154838
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
Review comment:
nit: note is in the form like this: https://github.com/apache/iceberg/blob/master/site/docs/spark-writes.md?plain=1#L298-L301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315725
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
+```bash
+./gradlew build
+```
+
+Votes are cast by replying to the release candidate announcement email on the dev mailing list
+with either +1, 0, or -1.
+
+> [ ] +1 Release this as Apache Iceberg ${VERSION}
+[ ] +0
+[ ] -1 Do not release this because...
+
+In addition to your vote, it's customary to specify if your vote is binding or non-binding. Only members
+of the Project Management Committee have formally binding votes. If you're unsure, you can specify that your
+vote is non-binding. To read more about voting in the Apache framework, checkout the
+[Voting](https://www.apache.org/foundation/voting.html) information page on the Apache foundation's website.
Review comment:
It's probably also helpful to add a couple helper sections for how to get the candidate running in Flink or Spark. Here's what I use for Spark:
```bash
/home/blue/Apps/spark-3.1.1-bin-hadoop3.2/bin/spark-shell \
--conf spark.jars.repositories=https://repository.apache.org/content/repositories/orgapacheiceberg-1019/ \
--packages org.apache.iceberg:iceberg-spark3-runtime:0.12.1 \
--conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
--conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
--conf spark.sql.catalog.local.type=hadoop \
--conf spark.sql.catalog.local.warehouse=/home/blue/tmp/hadoop-warehouse \
--conf spark.sql.catalog.local.default-namespace=default \
--conf spark.sql.catalog.prodhive=org.apache.iceberg.spark.SparkCatalog \
--conf spark.sql.catalog.prodhive.type=hive \
--conf spark.sql.catalog.prodhive.warehouse=/home/blue/tmp/prod-warehouse \
--conf spark.sql.catalog.prodhive.default-namespace=default \
--conf spark.sql.defaultCatalog=local
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-965136301
Updated the PR with all of the suggestions. Thanks everyone, this is ready for another review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r746580204
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
Review comment:
Removed the reference to a specific java version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753384555
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
Review comment:
Great idea, we can use `{{ extras.versions.iceberg }}`. Updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744164235
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
+```bash
+./gradlew build
Review comment:
Nit: `clean build` is probably preferred to eliminate caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r746580876
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
Review comment:
Thanks @jackye1995! I ended up removing this line but I used the right note syntax in another note I added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315197
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
Review comment:
I think it's good to avoid passive voice in documentation because it is more direct. I like the background here, but I think we can have both. How about something like this?
> Each Apache Iceberg release is validated by the community by holding a vote. A community release manager will prepare a release candidate and call a vote on the Iceberg dev list. To validate the release candidate, community members will test it out in their downstream projects and environments.
> In addition to testing in downstream projects, community members also check the release's signatures, checksums, and license documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315461
##########
File path: site/mkdocs.yml
##########
@@ -106,6 +106,7 @@ nav:
- Spec: spec.md
- Project:
- How To Release: how-to-release.md
+ - How To Vote: how-to-vote.md
Review comment:
How about "How to verify a release"? It isn't about voting, it's about validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751503568
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
Review comment:
Is it possible to use `{{ iceberg.version }}` from `mkdocs.yml` so that this stays up to date without a variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r748911215
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
Review comment:
This should be "Testing release binaries" and should probably go after "Testing a source release candidate". The ASF technically only releases source tarballs. Binaries are all "convenience" binaries and are not quite official. We don't really need to go into detail about the distinction on this page, but the more important information is supposed to be how to verify the source tarball, then how to test with the binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r749534522
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
Review comment:
This is one of those things that projects get in trouble for, so let's be sure to focus on the source based release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r748910901
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
Review comment:
"With the following" makes it sound like I can copy & paste. You might want to change it to "with a command like the following"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753385226
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
Review comment:
Changed it to "How to Verify a Release"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-962492491
Given the fact that we now have options for building against multiple Spark, Flink and Hive versions using different Java JDK versions, I think it's worth mentioning something in the line of:
> It is recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744039603
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
Review comment:
Does this need localhost with the new docs setup or can we use relative links?
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
On my MacBook, I don't have sha512sum. Maybe others do come with that by default, but I've been using `shasum -a 512` which is equivalent.
If others MacBooks have that (and they didn't install it themselves), ignore this. Otherwise we might consider changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751501063
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
Review comment:
Is there an automatic h1 heading based on the page name? Usually, we want the main heading to be the page name. This looks specific to just the first section. What about "Verifying a release" or "How to verify a release"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r748910814
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
Review comment:
Does this render correctly without a space between `!!!` and `Note`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r748911257
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+## Verifying with Flink
+
+To verify a candidate using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Announcement Content
Review comment:
Could this be a "Validating a source release candidate"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744048184
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
Updated with this note
**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-962494255
> Given the fact that we now have options for building against multiple Spark, Flink and Hive versions using different Java JDK versions, I think it's worth mentioning something in the line of:
>
> > It is recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+1. Especially for manual tests (eg not the unit tests), that’s really valuable to include as some users can’t or don’t upgrade very often (especially with Spark). If we all test with the latest supported versions, that’s something that would be nice to know so others can decide to run more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315373
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
+```bash
+./gradlew build
Review comment:
The tarball comes clean already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744048109
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
Review comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r749723245
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
Review comment:
I agree with focusing on the source release, but I don't think we actually want people to build their own maven artifacts. That would conflict with the main artifacts that will be published.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-974262224
Updated with additional comments. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r753618723
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,151 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# How to Verify a Release
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **KEYS file**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and KEYS file, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+curl https://dist.apache.org/repos/dist/dev/iceberg/KEYS -o KEYS
+gpg --import KEYS
+```
+
+Next, verify the `.asc` file.
+```bash
+gpg --verify apache-iceberg-{{ extra.versions.iceberg }}.tar.gz.asc
+```
+
+### Verifying Checksums
+
+```bash
+shasum -a 512 apache-iceberg-{{ extra.versions.iceberg }}.tar.gz.sha512
+```
+
+### Verifying License Documentation
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
Review comment:
Fixed, thanks for catching this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-974854929
Merged and deployed. Thanks, @samredai!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751502871
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Validating a source release candidate
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+### Verifying Signatures
+
+First, import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
Review comment:
Instead of `${PATH_TO_KEY_FILES}`, we can add a curl or wget command to download KEYS and then a command to import. There's only one `KEYS` file and it is in the same place across releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-974854929
Merged and deployed. Thanks, @samredai!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r749536223
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
Review comment:
Maybe it would make sense to also add a quick example of using the source release to publish a local maven artifact, and running off that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751313433
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
Review comment:
Updated the title to `Testing release binaries` and moved it after the `Validating a source release candidate` section. I also change `Verifying with Spark` and `Verifying with Flink` to be subsections here.
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+## Verifying with Flink
+
+To verify a candidate using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Announcement Content
Review comment:
I like it! Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751313822
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
+ Replace `${MAVEN_URL}` with the URL provided in the release announcement
+
+## Verifying with Spark
+
+To verify the candidate using spark, start a `spark-shell` with the following command:
+```bash
+spark-shell \
+ --conf spark.jars.repositories=${MAVEN_URL} \
+ --packages org.apache.iceberg:iceberg-spark3-runtime:${ICEBERG_VERSION} \
+ --conf spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions \
+ --conf spark.sql.catalog.local=org.apache.iceberg.spark.SparkCatalog \
+ --conf spark.sql.catalog.local.type=hadoop \
+ --conf spark.sql.catalog.local.warehouse=${LOCAL_WAREHOUSE_PATH} \
+ --conf spark.sql.catalog.local.default-namespace=default \
+ --conf spark.sql.defaultCatalog=local
+```
+
+## Verifying with Flink
+
+To verify a candidate using Flink, start a Flink SQL Client with the following command:
+```bash
+wget ${MAVEN_URL}/iceberg-flink-runtime/${ICEBERG_VERSION}/iceberg-flink-runtime-${ICEBERG_VERSION}.jar
+
+sql-client.sh embedded \
+ -j iceberg-flink-runtime-${ICEBERG_VERSION}.jar \
+ -j ${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_VERSION}-${FLINK_VERSION}.jar \
+ shell
+```
+
+## Announcement Content
+
+Release announcements include links to the following:
+
+- **A source tarball**
+- **A signature (.asc)**
+- **A checksum (.sha512)**
+- **Key files**
+- **GitHub change comparison**
+
+After downloading the source tarball, signature, checksum, and key files, here are instructions on how to
+verify signatures, checksums, and documentation.
+
+## Verifying Signatures
Review comment:
Done đź‘Ť
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Verify A Release page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r751311431
##########
File path: site/docs/how-to-verify-a-release.md
##########
@@ -0,0 +1,149 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# The Release Candidate
+
+Each Apache Iceberg release is validated by the community by holding a vote. A community release manager
+will prepare a release candidate and call a vote on the Iceberg
+[dev list](https://iceberg.apache.org/#community/#mailing-lists).
+To validate the release candidate, community members will test it out in their downstream projects and environments.
+It's recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+
+In addition to testing in downstream projects, community members also check the release's signatures, checksums, and
+license documentation.
+
+## Testing the Release Candidate
+
+Release candidate announcements will also include a maven repository location. You can use this
+location to test downstream dependencies by adding it to your maven or gradle build.
+
+To use the release candidate in your maven build, add the following to your `POM` or `settings.xml`:
+```xml
+...
+ <repositories>
+ <repository>
+ <id>iceberg-release-candidate</id>
+ <name>Iceberg Release Candidate</name>
+ <url>${MAVEN_URL}</url>
+ </repository>
+ </repositories>
+...
+```
+
+To use the release candidate in your gradle build, add the following to your `build.gradle`:
+```groovy
+repositories {
+ mavenCentral()
+ maven {
+ url "${MAVEN_URL}"
+ }
+}
+```
+
+!!!Note
Review comment:
It does but I went ahead and added the space for readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315342
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
Review comment:
Jack is right. We actually want people to check with other versions, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744315292
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
Can we give the `shasum -a 512` command instead? I have shasum on my linux machine so we probably just need that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744047638
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
Review comment:
Oops! Good catch, that was a copy-pasta mistake, lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744048184
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
Updated with this note
```md
**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
samredai commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744048184
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,74 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](http://127.0.0.1:8000/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
Review comment:
Updated with this note
> **note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#discussion_r744154937
##########
File path: site/docs/how-to-vote.md
##########
@@ -0,0 +1,75 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Voting on an Iceberg Release
+
+Before a new version of Apache Iceberg is released, a release candidate will be prepared and a vote
+will occur. Announcements will be made on the Iceberg [developer's mailing list](https://iceberg.apache.org/#community/#mailing-lists)
+and will include links to the following:
+
+- A source tarball
+- A signature (.asc)
+- A checksum (.sha512)
+- Key files
+- GitHub change comparison
+
+After downloading the source tarball, signature, checksum, and key files, follow
+these steps to participate in the voting process.
+
+Import the keys.
+```bash
+gpg --import ${PATH_TO_KEY_FILES}
+```
+
+Verify the signature.
+```bash
+gpg --verify apache-iceberg-${VERSION}.tar.gz.asc
+```
+
+Verify the checksum.
+```bash
+sha512sum -c apache-iceberg-${VERSION}.tar.gz.sha512
+```
+**note**: If you're on a mac that does not have coreutils installed, you can use `shasum -a 512` instead.
+
+Untar the archive and change into the source directory.
+```bash
+tar xzf apache-iceberg-${VERSION}.tar.gz
+cd apache-iceberg-${VERSION}
+```
+
+Run RAT checks to validate license headers.
+```bash
+dev/check-license
+```
+
+Build and test the project using Java 8.
Review comment:
I don't think we need to say java 8 explicitly, user should check using the java version they prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-962494255
> Given the fact that we now have options for building against multiple Spark, Flink and Hive versions using different Java JDK versions, I think it's worth mentioning something in the line of:
>
> > It is recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+1. Especially for manual tests (eg not the unit tests), that’s really valuable to include. If we all test with the latest supported versions, that’s something that would be nice to know so others can decide if they’d like to run more tests.
Some users can’t or don’t upgrade very often (especially with Spark), and it would be a disservice to them to not try to test the things we still actively support, especially as release manager etc.
I’d be interested in any thoughts on how to tackle this challenge (and how important it is), as we integrate with such a large number of tools and versions of each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #3479: Add a How To Vote page
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #3479:
URL: https://github.com/apache/iceberg/pull/3479#issuecomment-962494255
> Given the fact that we now have options for building against multiple Spark, Flink and Hive versions using different Java JDK versions, I think it's worth mentioning something in the line of:
>
> > It is recommended to report the Java, Scala, Spark, Flink and Hive versions you have tested against when you vote.
+1. Especially for manual tests (eg not the unit tests), that’s really valuable to include. If we all test with the latest supported versions, that’s something that would be nice to know so others can decide if they’d like to run more tests.
Some users can’t or don’t upgrade very often (especially with Spark), and it would be a disservice to them to not try to test the things we still actively support, especially as release manager etc. - even if users on older versions implicitly accept that this drift in support is not unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org