You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2025/02/05 15:47:37 UTC
[PR] Add another decimal cast edge test case [arrow-rs]
findepi opened a new pull request, #7078:
URL: https://github.com/apache/arrow-rs/pull/7078
Before 1019f5b27d3596077bcdd7e10b67e2c6d4cfbf02 this test would fail, as the cast produced 1. 0 is an edge case worth explicitly testing for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add another decimal cast edge test case [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #7078:
URL: https://github.com/apache/arrow-rs/pull/7078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add another decimal cast edge test case [arrow-rs]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #7078:
URL: https://github.com/apache/arrow-rs/pull/7078#discussion_r1943462840
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -10000,6 +10000,16 @@ mod tests {
result.unwrap().as_primitive::<Decimal128Type>().value(0),
520
);
+
+ // Cast 0 of dcimal(3,0) type to decimal(2,0)
Review Comment:
```suggestion
// Cast 0 of decimal(3, 0) type to decimal(2, 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add another decimal cast edge test case [arrow-rs]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #7078:
URL: https://github.com/apache/arrow-rs/pull/7078#issuecomment-2637384734
cc @felipecrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add another decimal cast edge test case [arrow-rs]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #7078:
URL: https://github.com/apache/arrow-rs/pull/7078#discussion_r1943728534
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -10000,6 +10000,16 @@ mod tests {
result.unwrap().as_primitive::<Decimal128Type>().value(0),
520
);
+
+ // Cast 0 of dcimal(3,0) type to decimal(2,0)
Review Comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org