[GitHub] [solr] dsmiley commented on a diff in pull request #1027: Add logs and comments to split workflow

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1027:
URL: https://github.com/apache/solr/pull/1027#discussion_r986063177


##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -302,6 +338,9 @@ public boolean split(ClusterState clusterState, ZkNodeProps message, NamedList<O
               firstNrtReplica);
       t.stop();
 
+      // 3. if this shard has attempted a split before and failed, there will be lingering INACTIVE
+      // sub-shards.
+      //    clean these up before proceeding

Review Comment:
   ```suggestion
         // sub-shards.  Clean these up before proceeding
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org