You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/03/20 23:05:44 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #3062: FINERACT-1853: Fix general accounting reports reconciliation
josehernandezfintecheandomx opened a new pull request, #3062:
URL: https://github.com/apache/fineract/pull/3062
## Description
Trial Balance Summary and Transaction Summary reports data are not reconciling with one and another, the Expectation is both the report values should match.
[FINERACT-1853](
https://issues.apache.org/jira/browse/FINERACT-1853)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #3062: FINERACT-1853: Fix general accounting reports reconciliation
Posted by "bharathcgowda (via GitHub)" <gi...@apache.org>.
bharathcgowda commented on PR #3062:
URL: https://github.com/apache/fineract/pull/3062#issuecomment-1477347566
@adamsaghy could you please help in the review of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3062: FINERACT-1853: Fix general accounting reports reconciliation
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3062:
URL: https://github.com/apache/fineract/pull/3062#discussion_r1143059398
##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0097_update_accounting_summary_table_reports.xml:
##########
@@ -0,0 +1,915 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">
+ <!-- Transaction Summary Report -->
+ <changeSet author="fineract" id="1">
+ <update tableName="stretchy_report">
+ <column name="report_sql" value="SELECT
+ '${endDate}' AS TransactionDate,
+ a.product AS Product,
+ (
+ SELECT
+ enum_message_property
+ FROM
+ r_enum_value
+ WHERE
+ enum_name = 'transaction_type_enum'
+ and enum_id = a.transaction_type
+ ) TransactionType_Name,
+ (
+ select
+ value
+ from
+ m_payment_type
+ where
+ id = a.payment_type_id
+ ) as PaymentType_Name,
+ a.chargetype as chargetype,
+ a.reversal_indicator AS Reversed,
+ a.Allocation_Type AS Allocation_Type,
+ '' AS Chargeoff_ReasonCode,
+ case when a.transaction_type IN (2, 23, 21, 22, 24, 4, 5, 8, 6, 27, 9,26)
+ AND a.reversal_indicator = false then sum(a.amount) * -1 when a.transaction_type IN (2, 23, 21, 22, 24, 4, 5, 8, 6, 27, 9,26)
+ AND a.reversal_indicator = true then sum(a.amount) * + 1 when a.transaction_type IN (1, 10, 25,20)
+ AND a.reversal_indicator = false then sum(a.amount) * + 1 when a.transaction_type IN (1, 10, 25,20)
+ AND a.reversal_indicator = true then sum(a.amount) * -1 end AS Transaction_Amount
+ FROM
+ (
+ SELECT
+ '${endDate}' AS transactiondate,
+ t.id,
+ l.name AS product,
+ t.transaction_type_enum AS transaction_type,
+ d.payment_type_id,
+ '' as chargetype,
Review Comment:
empty `chargetype`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3062: FINERACT-1853: Fix general accounting reports reconciliation
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3062:
URL: https://github.com/apache/fineract/pull/3062#issuecomment-1477485411
@josehernandezfintecheandomx is this tested on mysql and postgres as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3062: FINERACT-1853: Fix general accounting reports reconciliation
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3062:
URL: https://github.com/apache/fineract/pull/3062#discussion_r1143059180
##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0097_update_accounting_summary_table_reports.xml:
##########
@@ -0,0 +1,915 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd">
+ <!-- Transaction Summary Report -->
+ <changeSet author="fineract" id="1">
+ <update tableName="stretchy_report">
+ <column name="report_sql" value="SELECT
+ '${endDate}' AS TransactionDate,
+ a.product AS Product,
+ (
+ SELECT
+ enum_message_property
+ FROM
+ r_enum_value
+ WHERE
+ enum_name = 'transaction_type_enum'
+ and enum_id = a.transaction_type
+ ) TransactionType_Name,
+ (
+ select
+ value
+ from
+ m_payment_type
+ where
+ id = a.payment_type_id
+ ) as PaymentType_Name,
+ a.chargetype as chargetype,
+ a.reversal_indicator AS Reversed,
+ a.Allocation_Type AS Allocation_Type,
+ '' AS Chargeoff_ReasonCode,
Review Comment:
empty `Chargeoff_ReasonCode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #3062: FINERACT-1853: Fix general accounting reports reconciliation
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3062:
URL: https://github.com/apache/fineract/pull/3062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org