You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/17 18:50:50 UTC

[GitHub] [incubator-mxnet] sxjscience commented on pull request #19526: add bert-adam

sxjscience commented on pull request #19526:
URL: https://github.com/apache/incubator-mxnet/pull/19526#issuecomment-729129850


   Just to clarify. It should be called AdamW instead of BertAdam :) . Overall LGTM once you've added the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org