You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/02 03:33:52 UTC

[GitHub] [pulsar] HQebupt commented on pull request #16319: [Improve][broker] Use getMaxResourceUsageWithWeight instead of getMaxResourceUsage in selectBrokerForAssignment

HQebupt commented on PR #16319:
URL: https://github.com/apache/pulsar/pull/16319#issuecomment-1172825233

   > To me this fix makes sense. However, I am wondering if there was any reason why it uses `getMaxResourceUsage()` instead of `getMaxResourceUsageWithWeight()`.
   > 
   > The impact of this change could be broad(hopefully in a positive way) for the clusters that configure the resource weights differently.
   > 
   > Nevertheless, LGTM.
   
   I agree. The resource usage weight configurations only work in `ThresholdShedder` strategy currently. Why use `getMaxResourceUsage()` instead of `getMaxResourceUsageWithWeight()` in `LeastLongTermMessageRate`？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org